[vim keymap] Selection restored on undo #1038

New issue

Closed

opened 2012-12-03 06:40:55 +01:00 by marijnh · 2 comments

marijnh commented

2012-12-03 06:40:55 +01:00

(Migrated from gitlab.com)

If I delete some text in visual mode with like vjd, and then undo with u, the selection is restored after the undo. I think it might be due to the selection revamp in v3, since it does not occur on master.

I think may be expected behavior since it makes sense that if you select a chunk of text and delete it, undo restores the text and the selection. Just checking here, and making it a todo for myself to reset the cursor after undo in vim.js.

If I delete some text in visual mode with like `vjd`, and then undo with `u`, the selection is restored after the undo. I think it might be due to the selection revamp in v3, since it does not occur on master. I think may be expected behavior since it makes sense that if you select a chunk of text and delete it, undo restores the text and the selection. Just checking here, and making it a todo for myself to reset the cursor after undo in vim.js.

marijnh commented

2012-12-03 10:27:55 +01:00

(Migrated from gitlab.com)

See the discussion in #923 . This is indeed new in v3, and I'm not 100% certain that it makes sense, but it is more consistent than the vague heuristic I used before.

marijnh commented

2013-02-19 17:34:42 +01:00

(Migrated from gitlab.com)

mentioned in merge request !8420

marijnh (Migrated from gitlab.com) closed this issue

2013-05-20 15:26:28 +02:00

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

codemirror/codemirror5#1038

No description provided.

Rows
Columns