possible syntax hilighting bugfixes

marijnh commented

2011-06-14 18:00:32 +02:00

(Migrated from gitlab.com)

Hi,
I have a couple of commit on my fork:
github.com/ekhaled/CodeMirror2@f80b3d107d
github.com/ekhaled/CodeMirror2@0ab9ce1a9c

I did not supply these as pull requests because idk whether they are actual bugs or, whether I have missed something obvious

Please have a look and merge if appropriate...

thanks

Hi, I have a couple of commit on my fork: https://github.com/ekhaled/CodeMirror2/commit/f80b3d107d6918d32b63b07fef20faff6f15248d https://github.com/ekhaled/CodeMirror2/commit/0ab9ce1a9c3a54489cc7700d8343c331f71b6d41 I did not supply these as pull requests because idk whether they are actual bugs or, whether I have missed something obvious Please have a look and merge if appropriate... thanks

marijnh commented

2011-06-14 18:21:21 +02:00

(Migrated from gitlab.com)

Why didn't you just define true/false as keywords though? Seems that's what they are, not numbers.

marijnh commented

2011-06-14 18:32:50 +02:00

(Migrated from gitlab.com)

It's a minor fix, but I think you get the gist of my changes.

I quite like the way when you have "return true;" both keywords are not
coloured the same.
On Jun 14, 2011 5:21 PM, "marijnh" <
reply@reply.github.com>
wrote:

Why didn't you just define true/false as keywords though? Seems that's
what they are, not numbers.

Reply to this email directly or view it on GitHub:
https://github.com/marijnh/CodeMirror2/issues/117#issuecomment-1367164

It's a minor fix, but I think you get the gist of my changes. I quite like the way when you have "return true;" both keywords are not coloured the same. On Jun 14, 2011 5:21 PM, "marijnh" < reply@reply.github.com> wrote: > Why didn't you just define true/false as keywords though? Seems that's > what they are, not numbers. > > ## > > Reply to this email directly or view it on GitHub: > https://github.com/marijnh/CodeMirror2/issues/117#issuecomment-1367164

marijnh commented

2011-06-14 20:35:20 +02:00

(Migrated from gitlab.com)

There's an 'atom' style class, that's probably more suitable for true/false (I think that's what the JS mode uses for them). How about adding a configuration parameter for things that are considered atoms to the c-like mode? 'null' in Java could also go in there.

marijnh commented

2011-06-14 23:28:57 +02:00

(Migrated from gitlab.com)

+1 for the config parameter idea

marijnh (Migrated from gitlab.com) closed this issue

2011-06-14 23:28:57 +02:00

marijnh commented

2011-06-14 23:29:34 +02:00

(Migrated from gitlab.com)

Want to implement that?

marijnh commented

2011-06-14 23:36:37 +02:00

(Migrated from gitlab.com)

I will have a look, TBH I haven't dug too far into the highlighting code, and don't really understand it too well.
So can't really promise anything.
On a project right now (using CM), so will look at it when I have bit more time or run into the hiliter code again, whichever comes first :-)

I will have a look, TBH I haven't dug too far into the highlighting code, and don't really understand it too well. So can't really promise anything. On a project right now (using CM), so will look at it when I have bit more time or run into the hiliter code again, whichever comes first :-)

Rows
Columns

possible syntax hilighting bugfixes #117