CSS Theme should define .CodeMirror-activeline-background #1283

New issue

Closed

opened 2013-02-25 09:58:29 +01:00 by marijnh · 2 comments

marijnh commented

2013-02-25 09:58:29 +01:00

(Migrated from gitlab.com)

I think each css theme files should define the activeline background.

For instance CodeMirror\theme\eclipse.css should add :

.cm-s-eclipse .CodeMirror-activeline-background {background: #e8f2ff !important;}

Today there is style for matchingbreacket

.cm-s-eclipse .CodeMirror-matchingbracket {
border:1px solid grey;
color:black !important;;

}

so why not define too activeline?

I think each css theme files should define the activeline background. For instance CodeMirror\theme\eclipse.css should add : --- ## .cm-s-eclipse .CodeMirror-activeline-background {background: #e8f2ff !important;} Today there is style for matchingbreacket --- .cm-s-eclipse .CodeMirror-matchingbracket { border:1px solid grey; color:black !important;; ## } so why not define too activeline?

marijnh commented

2013-02-25 10:07:09 +01:00

(Migrated from gitlab.com)

I agree. I'll happily merge pull requests that add such a rule to theme files.

marijnh commented

2013-02-25 10:34:23 +01:00

(Migrated from gitlab.com)

Ok I will do that when I will have time.

marijnh (Migrated from gitlab.com) closed this issue

2013-05-20 15:21:52 +02:00

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

codemirror/codemirror5#1283

No description provided.

Rows
Columns