CodeMirror-gutter Re-size #3781

Closed
opened 2016-01-19 15:06:54 +01:00 by marijnh · 7 comments
marijnh commented 2016-01-19 15:06:54 +01:00 (Migrated from gitlab.com)

i am using the merge plugin. ( https://codemirror.net/demo/merge.html )

Scenario :
1 - Write a long commands on the same line
2- try to scroll right than left
3- gutters will move

Please check the attached files
i've tried to refresh the editor but it didn't worked .
how can i fix this ?

Thank you
Regards
screencapture-codemirror-net-demo-merge-html-1453211741453

i am using the merge plugin. ( https://codemirror.net/demo/merge.html ) Scenario : 1 - Write a long commands on the same line 2- try to scroll right than left 3- gutters will move Please check the attached files i've tried to refresh the editor but it didn't worked . how can i fix this ? Thank you Regards ![screencapture-codemirror-net-demo-merge-html-1453211741453](https://cloud.githubusercontent.com/assets/7591496/12420660/9f2cddf8-bec6-11e5-9d5f-aa5c2b856eab.png)
marijnh commented 2016-01-20 10:54:27 +01:00 (Migrated from gitlab.com)

Hi. This does not happen for me on Chrome. Which browser / version are you using?

Hi. This does not happen for me on Chrome. Which browser / version are you using?
marijnh commented 2016-01-20 11:00:45 +01:00 (Migrated from gitlab.com)

Hey, i am using Version 47.0.2526.111 (64-bit) on ubuntu

On Wed, Jan 20, 2016 at 11:54 AM, Marijn Haverbeke <notifications@github.com

wrote:

Hi. This does not happen for me on Chrome. Which browser / version are you
using?


Reply to this email directly or view it on GitHub
https://github.com/codemirror/CodeMirror/issues/3781#issuecomment-173150169
.

Hey, i am using Version 47.0.2526.111 (64-bit) on ubuntu On Wed, Jan 20, 2016 at 11:54 AM, Marijn Haverbeke <notifications@github.com > wrote: > > Hi. This does not happen for me on Chrome. Which browser / version are you > using? > > — > Reply to this email directly or view it on GitHub > https://github.com/codemirror/CodeMirror/issues/3781#issuecomment-173150169 > .
marijnh commented 2016-01-20 11:02:42 +01:00 (Migrated from gitlab.com)

Hm, that's exactly what I'm using. Could you describe your steps in more detail? When I go to the merge demo page, and scroll either of the editors right and then left, the gutter stays in place.

Hm, that's exactly what I'm using. Could you describe your steps in more detail? When I go to the merge demo page, and scroll either of the editors right and then left, the gutter stays in place.
marijnh commented 2016-01-20 11:23:50 +01:00 (Migrated from gitlab.com)
  1. Go the merge demo page
  2. Keep adding additional characters at the end of any line till the
    scrollbar on the left editor becomes clearly smaller than the one on the
    right
  3. Now when you scroll left and right on the left editor you will notice
    that the gutter will shift to the right

PS: this issue appears on Chrome Windows as well.

Thank you

On Wed, Jan 20, 2016 at 12:03 PM, Marijn Haverbeke <notifications@github.com

wrote:

Hm, that's exactly what I'm using. Could you describe your steps in more
detail? When I go to the merge demo page, and scroll either of the editors
right and then left, the gutter stays in place.


Reply to this email directly or view it on GitHub
https://github.com/codemirror/CodeMirror/issues/3781#issuecomment-173151848
.

1. Go the merge demo page 2. Keep adding additional characters at the end of any line till the scrollbar on the left editor becomes clearly smaller than the one on the right 3. Now when you scroll left and right on the left editor you will notice that the gutter will shift to the right PS: this issue appears on Chrome Windows as well. Thank you On Wed, Jan 20, 2016 at 12:03 PM, Marijn Haverbeke <notifications@github.com > wrote: > > Hm, that's exactly what I'm using. Could you describe your steps in more > detail? When I go to the merge demo page, and scroll either of the editors > right and then left, the gutter stays in place. > > — > Reply to this email directly or view it on GitHub > https://github.com/codemirror/CodeMirror/issues/3781#issuecomment-173151848 > .
marijnh commented 2016-01-22 21:58:04 +01:00 (Migrated from gitlab.com)

+1, I was able to reproduce it on
Browser Firefox
Mac

+1, I was able to reproduce it on Browser Firefox Mac
marijnh commented 2016-01-23 18:54:31 +01:00 (Migrated from gitlab.com)

Pull request to fix this #3788

Pull request to fix this #3788
marijnh (Migrated from gitlab.com) closed this issue 2016-01-24 22:38:23 +01:00
marijnh commented 2016-01-24 22:39:26 +01:00 (Migrated from gitlab.com)

The editor was clipping the horizontal scroll position wrong, leading to it believing it was setting its horizontal scroll somewhere the DOM wouldn't allow it to, confusing the gutter alignment code.

The editor was clipping the horizontal scroll position wrong, leading to it believing it was setting its horizontal scroll somewhere the DOM wouldn't allow it to, confusing the gutter alignment code.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/codemirror5#3781
No description provided.