Accessibility for blind and visually impaired screen reader users #4604

Closed
opened 2017-02-24 23:51:53 +01:00 by marijnh · 24 comments
marijnh commented 2017-02-24 23:51:53 +01:00 (Migrated from gitlab.com)

The known issue of lack of compatibility with screen readers and assistive technology completely prevents blind and visually impaired screen reader users from being able to use and participate in the enormous number of online tools and resources that use CodeMirror as their editor.
It would be wonderful if the need for full inclusion and accessibility support could be given priority by the CodeMirror community.
A working example of how this can be done quite successfully can be found here:
https://teachaccess.github.io/tutorial/

The known issue of lack of compatibility with screen readers and assistive technology completely prevents blind and visually impaired screen reader users from being able to use and participate in the enormous number of online tools and resources that use CodeMirror as their editor. It would be wonderful if the need for full inclusion and accessibility support could be given priority by the CodeMirror community. A working example of how this can be done quite successfully can be found here: https://teachaccess.github.io/tutorial/
marijnh commented 2017-02-25 11:09:40 +01:00 (Migrated from gitlab.com)

I think @marijnh and I are very interested in CodeMirror being accessible and useful to a broad range of people – supporting contentEditable is part of this as far as I know. Without specific funding we will not be able to address broad suggestions such as this, though. If there are specific, easy-to-solve issues, we might be able to fix them on the go.

I think `@marijnh` and I are very interested in CodeMirror being accessible and useful to a broad range of people – supporting `contentEditable` [is part of this](https://bugzilla.mozilla.org/show_bug.cgi?id=919711) as far as I know. Without specific funding we will not be able to address broad suggestions such as this, though. If there are specific, easy-to-solve issues, we might be able to fix them on the go.
marijnh (Migrated from gitlab.com) closed this issue 2017-02-25 11:09:40 +01:00
marijnh commented 2017-02-25 20:42:59 +01:00 (Migrated from gitlab.com)

The severe issue is that screen readers report the contents of the
editor to be blank and no cursor navigation or reading of the contents
is possible. The only thing that currently works is pressing CTRL+a to
select all to hear the editor contents which is not really useful.

It does sound like making the default contenteditable would be a major
improvement and step in the right direction.

Currently CodeMirror is simply unusable by an unfortunately large number
of people who depend on accessibility.

Hopefully the contenteditable change will be done soon.
On 2/25/2017 4:09 AM, Adrian Heine né Lang wrote:

I think @marijnh https://github.com/marijnh and I are very
interested in CodeMirror being accessible and useful to a broad range
of people – supporting |contentEditable| is part of this
https://bugzilla.mozilla.org/show_bug.cgi?id=919711 as far as I
know. Without specific funding we will not be able to address broad
suggestions such as this, though. If there are specific, easy-to-solve
issues, we might be able to fix them on the go.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/codemirror/CodeMirror/issues/4604#issuecomment-282474334,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APDp4pASGsBGoRzBtunrmoQQ9jfcQyWLks5rf_3sgaJpZM4MLxEz.

The severe issue is that screen readers report the contents of the editor to be blank and no cursor navigation or reading of the contents is possible. The only thing that currently works is pressing CTRL+a to select all to hear the editor contents which is not really useful. It does sound like making the default contenteditable would be a major improvement and step in the right direction. Currently CodeMirror is simply unusable by an unfortunately large number of people who depend on accessibility. Hopefully the contenteditable change will be done soon. On 2/25/2017 4:09 AM, Adrian Heine né Lang wrote: > > I think `@marijnh` <https://github.com/marijnh> and I are very > interested in CodeMirror being accessible and useful to a broad range > of people – supporting |contentEditable| is part of this > <https://bugzilla.mozilla.org/show_bug.cgi?id=919711> as far as I > know. Without specific funding we will not be able to address broad > suggestions such as this, though. If there are specific, easy-to-solve > issues, we might be able to fix them on the go. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/codemirror/CodeMirror/issues/4604#issuecomment-282474334>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/APDp4pASGsBGoRzBtunrmoQQ9jfcQyWLks5rf_3sgaJpZM4MLxEz>. >
marijnh commented 2017-02-25 20:55:05 +01:00 (Migrated from gitlab.com)

@mjanusauskas this won't be done soon - proper a11y support isn't easy (otherwise everyone would do it!), and the github tutorial doesn't come close to covering what CM will need. I've been doing significant work on a related project (and contributed small fixes back into CM) to do this right -- and I can assure you that contentEditable is just the beginning of what's needed.

`@mjanusauskas` this won't be done soon - proper a11y support isn't easy (otherwise everyone would do it!), and the github tutorial doesn't come close to covering what CM will need. I've been doing significant work on a [related project](https://bootstrapworld.github.io/codemirror-blocks/) (and contributed small fixes back into CM) to do this right -- and I can assure you that contentEditable is just the beginning of what's needed.
marijnh commented 2017-02-25 21:12:55 +01:00 (Migrated from gitlab.com)

@schanzer Thank you for the work you have been doing and for contributing back so many more can benefit from your work. While perhaps not easy, it is certain that incorporating accessibility from the beginning of a design is the best solution to avoiding the far more difficult work of trying to add it in later.

`@schanzer` Thank you for the work you have been doing and for contributing back so many more can benefit from your work. While perhaps not easy, it is certain that incorporating accessibility from the beginning of a design is the best solution to avoiding the far more difficult work of trying to add it in later.
marijnh commented 2017-07-16 23:41:36 +02:00 (Migrated from gitlab.com)

mentioned in issue #1801

mentioned in issue #1801
marijnh commented 2017-07-17 19:08:00 +02:00 (Migrated from gitlab.com)

Any estimates on roughly how much funding would be required to fund resolution of this issue?

Any estimates on roughly how much funding would be required to fund resolution of this issue?
marijnh commented 2017-08-24 06:35:22 +02:00 (Migrated from gitlab.com)

@adrianheine The WordPress project is looking at integrating CodeMirror into core (see https://github.com/WordPress/codemirror-wp). Given that WordPress puts a high importance on accessibility, there must be interest among the community in funding any needed accessibility improvements as well as funding ongoing maintenance.

`@adrianheine` The WordPress project is looking at integrating CodeMirror into core (see https://github.com/WordPress/codemirror-wp). Given that WordPress puts a high importance on accessibility, there must be interest among the community in funding any needed accessibility improvements as well as funding ongoing maintenance.
marijnh commented 2017-08-24 06:39:11 +02:00 (Migrated from gitlab.com)

mentioned in issue #22

mentioned in issue #22
marijnh commented 2017-11-21 00:45:39 +01:00 (Migrated from gitlab.com)

Without specific funding we will not be able to address broad suggestions such as this, though.

I understand that it will take some work, but choosing to do nothing is actively excluding an entire group of people. The accessibility dev community would likely get involved if an effort was identified.

> Without specific funding we will not be able to address broad suggestions such as this, though. I understand that it will take some work, but choosing to do nothing is actively excluding an entire group of people. The accessibility dev community would likely get involved if an effort was identified.
marijnh commented 2017-11-21 10:08:35 +01:00 (Migrated from gitlab.com)

We are aware of the problems and sympathetic to addressing them. The current architecture of the editor (which is still hugely influenced by the initial 'fake everything because browsers aren't reliable' approach) makes this very hard though. We are considering some radical changes, and with luck, we'll have an announcement about that soon. Pull request for low-hanging improvements are always very welcome (if properly documented so that we understand how hey actually improve things).

We are aware of the problems and sympathetic to addressing them. The current architecture of the editor (which is still hugely influenced by the initial 'fake everything because browsers aren't reliable' approach) makes this very hard though. We are considering some radical changes, and with luck, we'll have an announcement about that soon. Pull request for low-hanging improvements are always very welcome (if properly documented so that we understand how hey actually improve things).
marijnh commented 2017-11-28 00:08:48 +01:00 (Migrated from gitlab.com)

@marijnh & @adrianheine -

Potential approach to establish a baseline level of accessibility for CodeMirror:

Notes:

  • I haven't fully tested these approaches, as there are some complex things happening with the textarea within the CodeMirror js
  • Screenreader only content approach

Approach:

  • Create option for including checkbox to toggle CodeMirror instance for the textarea (formatting only - keeping apis, etc. intact)
  • Or include the checkbox (non-configurable) and hide it offscreen making it available for screenreader users, but not sighted ( I would argue that the option is beneficial for all, not just screenreader users)

-Any edit to the textarea or CodeMirror instance should update the other

demo: https://codepen.io/jasonday/pen/gXdeLm
(checkbox could live in a little settings drop in the upper right)

`@marijnh` & `@adrianheine` - Potential approach to establish a baseline level of accessibility for CodeMirror: Notes: - I haven't fully tested these approaches, as there are some complex things happening with the textarea within the CodeMirror js - Screenreader only content [approach](https://webaim.org/techniques/css/invisiblecontent/) Approach: - Create option for including checkbox to toggle CodeMirror instance for the textarea (formatting only - keeping apis, etc. intact) - Or include the checkbox (non-configurable) and hide it offscreen making it available for screenreader users, but not sighted ( I would argue that the option is beneficial for all, not just screenreader users) _-Any edit to the textarea or CodeMirror instance should update the other_ demo: https://codepen.io/jasonday/pen/gXdeLm (checkbox could live in a little settings drop in the upper right)
marijnh commented 2017-12-06 19:11:23 +01:00 (Migrated from gitlab.com)

@marijnh , would you be open to sharing some of the radical changes you're considering? I've made significant headway on a project aimed at improving the screen-reader accessibility of programming in general, which is built entirely around CodeMirror. I'm both curious about what you're thinking, but also just a little worried that any massive API changes will wreak havoc on my codebase.

`@marijnh` , would you be open to sharing some of the radical changes you're considering? I've made significant headway on a project aimed at improving the screen-reader accessibility of _programming in general_, which is built entirely around CodeMirror. I'm both curious about what you're thinking, but also just a *little* worried that any massive API changes will wreak havoc on my codebase.
marijnh commented 2017-12-07 11:04:00 +01:00 (Migrated from gitlab.com)

would you be open to sharing some of the radical changes you're considering?

We intend to move to contentEditable more completely. There'll be an announcement sometimes in the coming months when we have the design worked out more clearly.

but also just a little worried that any massive API changes will wreak havoc on my codebase.

Oh yeah, that will definitely happen, and upgrading will take some work.

> would you be open to sharing some of the radical changes you're considering? We intend to move to contentEditable more completely. There'll be an announcement sometimes in the coming months when we have the design worked out more clearly. > but also just a little worried that any massive API changes will wreak havoc on my codebase. Oh yeah, that will definitely happen, and upgrading will take some work.
marijnh commented 2018-01-01 05:14:28 +01:00 (Migrated from gitlab.com)

@marijnh This issue is really important to the freeCodeCamp.org community, which has many members who have visual impairments or are completely blind. Is there anything we can do to help with this?

`@marijnh` This issue is really important to the freeCodeCamp.org community, which has many members who have visual impairments or are completely blind. Is there anything we can do to help with this?
marijnh commented 2018-01-01 13:17:46 +01:00 (Migrated from gitlab.com)

@QuincyLarson Yes, there'll be work on a more accessible architecture starting in a few months. If you want to contribute financially or be involved in testing, shoot me an email!

`@QuincyLarson` Yes, there'll be work on a more accessible architecture starting in a few months. If you want to contribute financially or be involved in testing, shoot me an [email](marijnh@gmail.com)!
marijnh commented 2018-07-11 21:24:17 +02:00 (Migrated from gitlab.com)

mentioned in issue #4878

mentioned in issue #4878
marijnh commented 2019-04-14 13:15:35 +02:00 (Migrated from gitlab.com)

mentioned in issue #1012

mentioned in issue #1012
marijnh commented 2019-04-14 15:35:40 +02:00 (Migrated from gitlab.com)

mentioned in issue #1436

mentioned in issue #1436
marijnh commented 2019-08-20 23:51:23 +02:00 (Migrated from gitlab.com)

Any progress on this one?

Any progress on this one?
marijnh commented 2019-08-21 07:39:32 +02:00 (Migrated from gitlab.com)

Work on CodeMirror 6 is progressing in this repository.

Work on CodeMirror 6 is progressing in [this repository](https://github.com/codemirror/codemirror.next).
marijnh commented 2019-08-21 08:10:29 +02:00 (Migrated from gitlab.com)

Thank you, 6.x looks nice from the accessibility perspective.

Thank you, 6.x looks nice from the accessibility perspective.
marijnh commented 2020-03-30 13:42:51 +02:00 (Migrated from gitlab.com)

any update?

any update?
marijnh commented 2020-09-27 05:56:30 +02:00 (Migrated from gitlab.com)

mentioned in issue #2894

mentioned in issue #2894
marijnh commented 2024-05-05 23:48:30 +02:00 (Migrated from gitlab.com)

mentioned in issue #730

mentioned in issue #730
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/codemirror5#4604
No description provided.