Overlapping scroll thumbs appear on Lion #727

Closed
opened 2012-08-15 23:05:58 +02:00 by marijnh · 7 comments
marijnh commented 2012-08-15 23:05:58 +02:00 (Migrated from gitlab.com)

As of commit 472d099bef

  1. Open demo/theme.html on Mac OS X Lion
  2. Paste in codemirror.js
  3. Scroll down towards the bottom

Result: You see two overlapping scrollbar thumbs on the right. They diverge more and more as you get closer to the bottom of the code. (Even if they matched, though, it would still look wrong since the scrollbar thumb would be twice as dark as usual.)

As of commit 472d099befcca4381b3a449db9010fe3fbaafa0f 1. Open demo/theme.html on Mac OS X Lion 2. Paste in codemirror.js 3. Scroll down towards the bottom Result: You see two overlapping scrollbar thumbs on the right. They diverge more and more as you get closer to the bottom of the code. (Even if they matched, though, it would still look wrong since the scrollbar thumb would be twice as dark as usual.)
marijnh commented 2012-08-24 20:24:11 +02:00 (Migrated from gitlab.com)

I'm working on a new scrolling model (tracked in #730) that I think will fix this. It's a pretty bizarre hack (basically, making the scroller bigger than the wrapper, in order to hide its scrollbars, and then compensating for this with padding and overflow: hidden on the wrapper), but it seems to work on all supported browsers.

I'm working on a new scrolling model (tracked in #730) that I think will fix this. It's a pretty bizarre hack (basically, making the scroller bigger than the wrapper, in order to hide its scrollbars, and then compensating for this with padding and overflow: hidden on the wrapper), but it seems to work on all supported browsers.
marijnh commented 2012-08-28 14:56:04 +02:00 (Migrated from gitlab.com)

The v3 branch now contains the solution outlined above. It seems to work.

The v3 branch now contains the solution outlined above. It seems to work.
marijnh commented 2012-09-05 02:58:29 +02:00 (Migrated from gitlab.com)

Hi Marijn--sorry for the late response on this. I just tried demo/theme.html in the v3 branch, pasting in a long file, and on Lion I don't see the scroll thumb at all (though it does scroll if I use the touchpad). Also, the scrolling is flickery on long/fast throws.

Hi Marijn--sorry for the late response on this. I just tried demo/theme.html in the v3 branch, pasting in a long file, and on Lion I don't see the scroll thumb at all (though it does scroll if I use the touchpad). Also, the scrolling is flickery on long/fast throws.
marijnh commented 2012-09-05 03:21:43 +02:00 (Migrated from gitlab.com)

I should mention that I'm testing in Chrome 21.0.1180.89.

I should mention that I'm testing in Chrome 21.0.1180.89.
marijnh commented 2012-09-05 09:59:06 +02:00 (Migrated from gitlab.com)

That's not surprising. I haven't debugged at all on Lion, so there's bound to be some issues with A) getting the fake scrollbar div to even display its scrollbar (it's probably getting its width set to zero since scrollbars take up zero space), and B) correctly handling mouse clicks in that scrollbar.

Will you have time to debug this somewhere this month?

I tried to install Mountain Lion on my old MacBook Pro (couldn't find 10.7 in the app store), but it claims that the computer isn't compatible with that version (though it meets all the requirements listed at http://support.apple.com/kb/HT5444). So, since I don't currently have much intention to pay large amounts of money for a new Apple laptop, I am not able to test and debug this.

That's not surprising. I haven't debugged at all on Lion, so there's bound to be some issues with A) getting the fake scrollbar div to even display its scrollbar (it's probably getting its width set to zero since scrollbars take up zero space), and B) correctly handling mouse clicks in that scrollbar. Will you have time to debug this somewhere this month? I tried to install Mountain Lion on my old MacBook Pro (couldn't find 10.7 in the app store), but it claims that the computer isn't compatible with that version (though it meets all the requirements listed at http://support.apple.com/kb/HT5444). So, since I don't currently have much intention to pay large amounts of money for a new Apple laptop, I am not able to test and debug this.
marijnh commented 2012-09-06 17:34:15 +02:00 (Migrated from gitlab.com)

With the above patch, scrollbars seem to work for me on Lion (which I managed to install through a somewhat creative process) on v3. In 2.x, I intend to leave things as they are (fake scrollbar disabled, so flickering present, but otherwise all should be fine).

With the above patch, scrollbars seem to work for me on Lion (which I managed to install through a somewhat creative process) on v3. In 2.x, I intend to leave things as they are (fake scrollbar disabled, so flickering present, but otherwise all should be fine).
marijnh (Migrated from gitlab.com) closed this issue 2012-09-06 17:34:16 +02:00
marijnh commented 2012-09-08 02:58:37 +02:00 (Migrated from gitlab.com)

Yup, looks like the scrollbars are working again--and I can grab them as well, which is great!

I'm still seeing noticeable flicker on long throws, especially in the gutter area. There's also a minor visual issue with the fake scrollbar on Mountain Lion (which changed the scrollbars slightly yet again...). I'll file separate bugs on these.

Yup, looks like the scrollbars are working again--and I can grab them as well, which is great! I'm still seeing noticeable flicker on long throws, especially in the gutter area. There's also a minor visual issue with the fake scrollbar on Mountain Lion (which changed the scrollbars slightly yet again...). I'll file separate bugs on these.
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/codemirror5#727
No description provided.