codemirror/dev
1
4
Fork 0
Code Issues 19 Pull requests Activity

Website's style #360

New issue
Closed
opened 2020-12-30 18:43:31 +01:00 by GitCodeDestroyer · 9 comments
GitCodeDestroyer commented 2020-12-30 18:43:31 +01:00 (Migrated from github.com)
Copy link

I think you should use Consolas as a default code font-family for better view.

I think you should use Consolas as a default code `font-family` for better view.
marijnh commented 2020-12-30 19:13:34 +01:00 (Migrated from github.com)
Copy link

That's windows-only, isn't it?

That's windows-only, isn't it?
curran commented 2020-12-30 21:08:05 +01:00 (Migrated from github.com)
Copy link

This is the system font stack that GitHub uses for code:

SFMono-Regular,Consolas,Liberation Mono,Menlo,monospace
This is the system font stack that GitHub uses for code: ``` SFMono-Regular,Consolas,Liberation Mono,Menlo,monospace ```
marijnh commented 2021-01-04 13:25:34 +01:00 (Migrated from github.com)
Copy link

Thanks, I'll just copy those and hope they look good on all platforms (seem fine on Linux)

Thanks, I'll just copy those and hope they look good on all platforms (seem fine on Linux)
mischnic commented 2021-01-04 13:36:52 +01:00 (Migrated from github.com)
Copy link

That declaration seems to be ignored for me on Chrome?

Bildschirmfoto 2021-01-04 um 13 35 43
That declaration seems to be ignored for me on Chrome? <img width="511" alt="Bildschirmfoto 2021-01-04 um 13 35 43" src="https://user-images.githubusercontent.com/4586894/103535833-bfcc6500-4e91-11eb-8e31-32d90da74bbc.png">
marijnh commented 2021-01-04 14:21:26 +01:00 (Migrated from github.com)
Copy link

Ugh, indeed. I've followed up with another patch.

Ugh, indeed. I've followed up with another patch.
mischnic commented 2021-01-04 14:33:54 +01:00 (Migrated from github.com)
Copy link

Firefox and Safari works now, but still not on Chrome:

Bildschirmfoto 2021-01-04 um 14 33 06
Firefox and Safari works now, but still not on Chrome: <img width="513" alt="Bildschirmfoto 2021-01-04 um 14 33 06" src="https://user-images.githubusercontent.com/4586894/103540262-c363ea00-4e99-11eb-89e6-49f7d1e5c834.png">
marijnh commented 2021-01-04 15:22:24 +01:00 (Migrated from github.com)
Copy link

Hah, that uncovered an issue in style-mod where adoptedStyleSheets, which is uses when available (on Chrome) doesn't produce the precedence ordering I expected. Should be fixed now... hopefully.

Hah, that uncovered an issue in style-mod where `adoptedStyleSheets`, which is uses when available (on Chrome) doesn't produce the [precedence ordering](https://github.com/WICG/construct-stylesheets/issues/93) I expected. Should be fixed now... hopefully.
mischnic commented 2021-01-04 15:32:38 +01:00 (Migrated from github.com)
Copy link

It's working now 👍

It's working now 👍
curran commented 2021-01-04 17:08:24 +01:00 (Migrated from github.com)
Copy link

Hooray! Great that this uncovered an issue in style-mod and led to a fix.

Hooray! Great that this uncovered an issue in style-mod and led to a fix.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
0.16.0
0.15.0
0.14.0
0.13.1
0.13.0
0.12.0
0.11.0
0.10.0
0.9.0
0.8.0
0.7.1
0.7.0
0.6.0
0.5.2
0.5.3
0.5.1
0.5.0
0.4.0
0.3.0
0.2.0
0.1.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/dev#360
No description provided.