Search extension behaviors

rdesille commented

2021-05-26 11:03:14 +02:00

(Migrated from github.com)

Hi,

I'd like to "improve" the search extension.

Fill search input with selection when Mod-f is pressed
Split panel into a search and a replace panel
(Mod-f would display only search panel while Mod-r/Mod-h would display both)
Adding some configuration (panel position, ...)
Allow user to provide its own panel DOM ...

Would it fit with you vision of the extension? Are you interested by such "behaviors" ?
if you like the idea, I would be please to work on it and submit a PR when it would be ready.

Romain

Hi, I'd like to "improve" the search extension. * Fill search input with selection when Mod-f is pressed * Split panel into a search and a replace panel (Mod-f would display only search panel while Mod-r/Mod-h would display both) * Adding some configuration (panel position, ...) * Allow user to provide its own panel DOM ... Would it fit with you vision of the extension? Are you interested by such "behaviors" ? if you like the idea, I would be please to work on it and submit a PR when it would be ready. Romain

marijnh commented

2021-05-26 11:34:39 +02:00

(Migrated from github.com)

The first point, and an option to put the panel at the top of the editor, sound like good ideas. The others are out of scope for the core library—there's a million ways to do a search panel, and I don't want to try and cover all of them with this package.

rdesille commented

2021-05-26 11:41:06 +02:00

(Migrated from github.com)

That make sense. Do you want me to work on those two points ?

marijnh commented

2021-05-27 10:46:05 +02:00

(Migrated from github.com)

Attached patches implement these features.

Rows
Columns

Search extension behaviors #496