lezer/css
1
0
Fork 0
Code Issues Pull requests Activity

Tokenizing grid property with line names are interpreted incorrectly #10

New issue
Closed
opened 2023-12-29 14:32:45 +01:00 by ergunsh · 4 comments
ergunsh commented 2023-12-29 14:32:45 +01:00 (Migrated from github.com)
Copy link

Hey @marijnh,

It seems like tokenizing this not working correctly:

* {
    grid: [linename1] "a" 100px [linename2];
}

The property declaration is resolved to be a RuleSet instead of a Declaration.

Can you take a look please? :)

Hey @marijnh, It seems like tokenizing this not working correctly: ```css * { grid: [linename1] "a" 100px [linename2]; } ``` The property declaration is resolved to be a `RuleSet` instead of a `Declaration`. Can you take a look please? :)
marijnh commented 2023-12-29 16:03:32 +01:00 (Migrated from github.com)
Copy link

What is that [linename1] syntax? Is that CSS, some extension, or just a placeholder in your example?

What is that `[linename1]` syntax? Is that CSS, some extension, or just a placeholder in your example?
tophf commented 2023-12-29 16:53:06 +01:00 (Migrated from github.com)
Copy link

It's CSS syntax: https://drafts.csswg.org/css-grid/#typedef-line-names

It's CSS syntax: https://drafts.csswg.org/css-grid/#typedef-line-names
marijnh commented 2024-01-01 15:19:42 +01:00 (Migrated from github.com)
Copy link

That wasn't part of our CSS parser yet. Can you check if the attached patch helps with this?

That wasn't part of our CSS parser yet. Can you check if the attached patch helps with this?
ergunsh commented 2024-01-03 14:01:48 +01:00 (Migrated from github.com)
Copy link

Yep, this solves our issue; thanks! :)

Yep, this solves our issue; thanks! :)
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
1.3.3
1.3.2
1.3.1
1.3.0
1.2.1
1.2.0
1.1.11
1.1.10
1.1.9
1.1.8
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.1
1.0.0
0.16.0
0.15.2
0.15.1
0.15.0
0.13.1
0.13.0
0.12.0
0.11.1
0.11.0
0.10.1
0.10.0
0.9.0
0.8.3
0.8.2
0.8.1
0.8.0
0.7.0
0.5.2
0.5.1
0.5.0
0.4.0
0.3.0
0.2.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lezer/css#10
No description provided.