lezer/css
1
0
Fork 0
Code Issues Pull requests Activity

Tokenizing a property declaration with a space after property name resolves incorrectly to RuleSet instead of Declaration #11

New issue
Closed
opened 2024-01-04 13:46:43 +01:00 by ergunsh · 3 comments
ergunsh commented 2024-01-04 13:46:43 +01:00 (Migrated from github.com)
Copy link

Hey @marijnh,

It seems like when there is a space betwen the property name and the colon, the tokenizing fails; see the following case:

div {
    color: blue;
    color : red;
}

color: blue resolves correctly to Declaration; however color : red resolves to RuleSet.

I have created a tree visualizer for @lezer/css and @lezer/javascript; you can take a look here as well: https://ergun.sh/lezer-viz.html?language=%40lezer%2Fcss&sourceText=*+%7B%0A++color%3A+red%3B%0A++color+%3A+blue%3B%0A%7D

Hey @marijnh, It seems like when there is a space betwen the property name and the colon, the tokenizing fails; see the following case: ``` div { color: blue; color : red; } ``` `color: blue` resolves correctly to `Declaration`; however `color : red` resolves to `RuleSet`. I have created a tree visualizer for `@lezer/css` and `@lezer/javascript`; you can take a look here as well: https://ergun.sh/lezer-viz.html?language=%40lezer%2Fcss&sourceText=*+%7B%0A++color%3A+red%3B%0A++color+%3A+blue%3B%0A%7D
marijnh commented 2024-01-04 14:51:27 +01:00 (Migrated from github.com)
Copy link

This patch should help. It was getting confused because (since it supports nested rules) it was interpreting that colon as indicating some selector like p :pseudoclass was coming.

This patch should help. It was getting confused because (since it supports nested rules) it was interpreting that colon as indicating some selector like `p :pseudoclass` was coming.
ergunsh commented 2024-01-08 12:40:29 +01:00 (Migrated from github.com)
Copy link

Ah perfect, thanks for the quick patch again! :)

Do you have a time when the fix would be published?

Ah perfect, thanks for the quick patch again! :) Do you have a time when the fix would be published?
marijnh commented 2024-01-08 13:17:03 +01:00 (Migrated from github.com)
Copy link

I've tagged this in @lezer/css 1.1.7

I've tagged this in @lezer/css 1.1.7
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
1.3.3
1.3.2
1.3.1
1.3.0
1.2.1
1.2.0
1.1.11
1.1.10
1.1.9
1.1.8
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.1
1.0.0
0.16.0
0.15.2
0.15.1
0.15.0
0.13.1
0.13.0
0.12.0
0.11.1
0.11.0
0.10.1
0.10.0
0.9.0
0.8.3
0.8.2
0.8.1
0.8.0
0.7.0
0.5.2
0.5.1
0.5.0
0.4.0
0.3.0
0.2.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lezer/css#11
No description provided.