lezer/css
1
0
Fork 0
Code Issues Pull requests Activity

Empty value incorrectly parsed as a syntax error #13

New issue
Closed
opened 2024-09-10 15:28:01 +02:00 by pfaffe · 3 comments
pfaffe commented 2024-09-10 15:28:01 +02:00 (Migrated from github.com)
Copy link
  --foo: ;
}

Is parsed as a syntax error, but this is a valid declaration. Should it be an empty-string ValueName?

```* { --foo: ; } ``` Is parsed as a syntax error, but this is a valid declaration. Should it be an empty-string ValueName?
marijnh commented 2024-09-10 15:34:56 +02:00 (Migrated from github.com)
Copy link

Oh wow, I did not know that. We could make value optional in the rule for Declaration. Would that work for you?

Oh wow, I did not know that. We could make `value` optional in the rule for `Declaration`. Would that work for you?
pfaffe commented 2024-09-10 15:51:09 +02:00 (Migrated from github.com)
Copy link

I could work with that. Is that easier than allowing ValueName to be empty?

I could work with that. Is that easier than allowing ValueName to be empty?
marijnh commented 2024-09-10 15:55:47 +02:00 (Migrated from github.com)
Copy link

There's no real value name there, it's just a missing value entirely, so generating an empty node seems needlessly indirect.

Attached patch implements this.

There's no real value name there, it's just a missing value entirely, so generating an empty node seems needlessly indirect. Attached patch implements this.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
1.3.3
1.3.2
1.3.1
1.3.0
1.2.1
1.2.0
1.1.11
1.1.10
1.1.9
1.1.8
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.1
1.0.0
0.16.0
0.15.2
0.15.1
0.15.0
0.13.1
0.13.0
0.12.0
0.11.1
0.11.0
0.10.1
0.10.0
0.9.0
0.8.3
0.8.2
0.8.1
0.8.0
0.7.0
0.5.2
0.5.1
0.5.0
0.4.0
0.3.0
0.2.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lezer/css#13
No description provided.