lezer/css
1
0
Fork 0
Code Issues Pull requests Activity

Tokenizing VariableName with escaped characters is not working #9

New issue
Closed
opened 2023-11-08 16:11:03 +01:00 by ergunsh · 2 comments
ergunsh commented 2023-11-08 16:11:03 +01:00 (Migrated from github.com)
Copy link

Hey @marijnh,

Currently, tokenizing variable names with escape characters are not working properly.

This should tokenize correctly: var(--\\) as a CallExpression with VariableName that is equal to the --\\, according to the spec.

We're slowly replacing our regex based parser with CodeMirror parser but this has blocked us for moving forward with replacing how we do custom property parsing. Failing test cases are here.

WDYT, can you take a look?

Hey @marijnh, Currently, tokenizing variable names with escape characters are not working properly. This should tokenize correctly: `var(--\\)` as a CallExpression with VariableName that is equal to the `--\\`, according to the [spec](https://www.w3.org/TR/css-syntax-3/#consume-string-token). We're slowly replacing our regex based parser with CodeMirror parser but this has blocked us for moving forward with replacing how we do custom property parsing. Failing test cases are [here](https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/test/unittests/front_end/core/sdk/CSSMatchedStyles_test.ts;l=26?q=cssMatchedStyles_test). WDYT, can you take a look?
marijnh commented 2023-11-09 11:12:01 +01:00 (Migrated from github.com)
Copy link

Attached patch should help (tagged 1.1.4).

Attached patch should help (tagged 1.1.4).
ergunsh commented 2023-11-09 11:43:22 +01:00 (Migrated from github.com)
Copy link

whoa, thanks a lot for the quick fix! :)

whoa, thanks a lot for the quick fix! :)
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
1.3.3
1.3.2
1.3.1
1.3.0
1.2.1
1.2.0
1.1.11
1.1.10
1.1.9
1.1.8
1.1.7
1.1.6
1.1.5
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.1
1.0.0
0.16.0
0.15.2
0.15.1
0.15.0
0.13.1
0.13.0
0.12.0
0.11.1
0.11.0
0.10.1
0.10.0
0.9.0
0.8.3
0.8.2
0.8.1
0.8.0
0.7.0
0.5.2
0.5.1
0.5.0
0.4.0
0.3.0
0.2.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lezer/css#9
No description provided.