lezer/javascript
1
0
Fork 0
Code Issues Pull requests Activity

bitwise operator precedence is wrong #27

New issue
Closed
opened 2024-01-10 03:18:03 +01:00 by jedwards1211 · 1 comment
jedwards1211 commented 2024-01-10 03:18:03 +01:00 (Migrated from github.com)
Copy link

This probably doesn't affect anything this grammar is being used for, but FWIW...

The grammar defines precedence

  bitOr @left,
  bitXor @left,
  bitAnd @left,

But according to MDN the correct precedence is

7: bitwise AND left-to-right Bitwise ANDx & y
6: bitwise XOR left-to-right Bitwise XORx ^ y
5: bitwise OR left-to-right Bitwise ORx | y
This probably doesn't affect anything this grammar is being used for, but FWIW... The grammar defines precedence ``` bitOr @left, bitXor @left, bitAnd @left, ``` But [according to MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Operator_precedence) the correct precedence is 7: bitwise AND | left-to-right | Bitwise ANDx & y -- | -- | -- 6: bitwise XOR | left-to-right | Bitwise XORx ^ y 5: bitwise OR | left-to-right | Bitwise ORx \| y
marijnh commented 2024-01-10 09:51:59 +01:00 (Migrated from github.com)
Copy link

Thanks for spotting that. Merged.

Thanks for spotting that. Merged.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.2
1.3.1
1.3.0
1.2.0
1.1.1
1.1.0
1.0.2
1.0.1
1.0.0
0.16.0
0.15.3
0.15.2
0.15.1
0.15.0
0.13.4
0.13.3
0.13.2
0.13.1
0.13.0
0.12.0
0.11.1
0.11.0
0.10.1
0.10.0
0.9.1
0.9.0
0.8.4
0.8.3
0.8.2
0.8.1
0.8.0
0.7.0
0.5.2
0.5.1
0.5.0
0.4.0
0.3.0
0.2.0
0.1.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lezer/javascript#27
No description provided.