Ternary with numbers fails to parse when minified #33

New issue

Closed

opened 2024-04-23 09:27:50 +02:00 by szuend · 2 comments

szuend commented 2024-04-23 09:27:50 +02:00 (Migrated from github.com)

Copy link

Not sure how relevant this is for authored code, but bundlers remove spaces and leading zeroes from numbers. The snippet

foo?.1:2

currently fails to parse. Since I'm only superficially familiar with how Lezer grammar works, I don't actually know how a fix would look like. I'd have expected the parser to backtrack from the failed MemberExpression and try the ConditionalExpression, but maybe the tokenizer eagerly combined the ?. so the ConditionalExpression can't be applied?

Not sure how relevant this is for authored code, but bundlers remove spaces and leading zeroes from numbers. The snippet ``` foo?.1:2 ``` currently fails to parse. Since I'm only superficially familiar with how Lezer grammar works, I don't actually know how a fix would look like. I'd have expected the parser to backtrack from the failed `MemberExpression` and try the `ConditionalExpression`, but maybe the tokenizer eagerly combined the `?.` so the `ConditionalExpression` can't be applied?

marijnh commented 2024-04-23 11:18:32 +02:00 (Migrated from github.com)

Copy link

This seems to be something to handle at the token level—?. is only a deref operator when not followed by a digit. Attached patch uses an external tokenizer to implement it that way.

This seems to be something to handle at the token level—`?.` is only a deref operator when not followed by a digit. Attached patch uses an external tokenizer to implement it that way.

szuend commented 2024-04-23 12:19:17 +02:00 (Migrated from github.com)

Copy link

Nice! Thanks for the fast fix.

Nice! Thanks for the fast fix.

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.21

1.4.20

1.4.19

1.4.18

1.4.17

1.4.16

1.4.15

1.4.14

1.4.13

1.4.12

1.4.11

1.4.10

1.4.9

1.4.8

1.4.7

1.4.6

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.2

1.3.1

1.3.0

1.2.0

1.1.1

1.1.0

1.0.2

1.0.1

1.0.0

0.16.0

0.15.3

0.15.2

0.15.1

0.15.0

0.13.4

0.13.3

0.13.2

0.13.1

0.13.0

0.12.0

0.11.1

0.11.0

0.10.1

0.10.0

0.9.1

0.9.0

0.8.4

0.8.3

0.8.2

0.8.1

0.8.0

0.7.0

0.5.2

0.5.1

0.5.0

0.4.0

0.3.0

0.2.0

0.1.0

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lezer/javascript#33

No description provided.