lezer/javascript
1
0
Fork 0
Code Issues Pull requests Activity

TS: Support ? for method declarations in interfaces #37

New issue
Closed
opened 2024-10-08 15:21:42 +02:00 by SirPepe · 3 comments
SirPepe commented 2024-10-08 15:21:42 +02:00 (Migrated from github.com)
Copy link

The grammar does not appear to understand the foo?(): number; bit of the following:

interface Test { foo?(): number; }

declare var t: Test;

t.foo() // Cannot invoke an object which is possibly 'undefined'

https://www.typescriptlang.org/play/?#code/JYOwLgpgTgZghgYwgAgCoQM5mQb2TAewIH4AKASgC5kQBXAWwCNoBuZAXwChOATCBADZwoKAG7DkYauiwtuYAHSECFZAHo1yAMJwQIAtlCiCAaxS7kBRgCt+2AO4ALYAkfJgGZAAcCGDMEYBAE9kAHJaED4YUAgeUKA

The grammar does not appear to understand the `foo?(): number;` bit of the following: ``` interface Test { foo?(): number; } declare var t: Test; t.foo() // Cannot invoke an object which is possibly 'undefined' ``` https://www.typescriptlang.org/play/?#code/JYOwLgpgTgZghgYwgAgCoQM5mQb2TAewIH4AKASgC5kQBXAWwCNoBuZAXwChOATCBADZwoKAG7DkYauiwtuYAHSECFZAHo1yAMJwQIAtlCiCAaxS7kBRgCt+2AO4ALYAkfJgGZAAcCGDMEYBAE9kAHJaED4YUAgeUKA
marijnh commented 2024-10-08 16:18:47 +02:00 (Migrated from github.com)
Copy link

Implemented in attached patch. Got any more of these coming or shall I cut a release?

Implemented in attached patch. Got any more of these coming or shall I cut a release?
SirPepe commented 2024-10-08 17:22:59 +02:00 (Migrated from github.com)
Copy link

That's all, at least for the next few days! Thank you.

That's all, at least for the next few days! Thank you.
marijnh commented 2024-10-08 17:41:14 +02:00 (Migrated from github.com)
Copy link

Tagged 1.4.19

Tagged 1.4.19
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.2
1.3.1
1.3.0
1.2.0
1.1.1
1.1.0
1.0.2
1.0.1
1.0.0
0.16.0
0.15.3
0.15.2
0.15.1
0.15.0
0.13.4
0.13.3
0.13.2
0.13.1
0.13.0
0.12.0
0.11.1
0.11.0
0.10.1
0.10.0
0.9.1
0.9.0
0.8.4
0.8.3
0.8.2
0.8.1
0.8.0
0.7.0
0.5.2
0.5.1
0.5.0
0.4.0
0.3.0
0.2.0
0.1.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lezer/javascript#37
No description provided.