lezer/javascript
1
0
Fork 0
Code Issues Pull requests Activity

Parser chokes on TypeScript method #48

New issue
Closed
opened 2025-09-18 13:33:46 +02:00 by bmeurer · 3 comments
bmeurer commented 2025-09-18 13:33:46 +02:00 (Migrated from github.com)
Copy link

In the context of crbug.com/445874747 I realized that the TypeScript grammar seems to choke on some perfectly valid TypeScript: I minimized it to this already.

In the context of [crbug.com/445874747](http://crbug.com/445874747) I realized that the TypeScript grammar seems to choke on some perfectly valid TypeScript: I minimized it to [this](https://codemirror.net/try/#c=aW1wb3J0IHtiYXNpY1NldHVwLCBFZGl0b3JWaWV3fSBmcm9tICJjb2RlbWlycm9yIgppbXBvcnQge2phdmFzY3JpcHR9IGZyb20gIkBjb2RlbWlycm9yL2xhbmctamF2YXNjcmlwdCIKCm5ldyBFZGl0b3JWaWV3KHsKICBkb2M6ICJjb25zb2xlLmxvZygnaGVsbG8nKVxuIiwKICBleHRlbnNpb25zOiBbYmFzaWNTZXR1cCwgamF2YXNjcmlwdCh7dHlwZXNjcmlwdDogdHJ1ZX0pXSwKICBwYXJlbnQ6IGRvY3VtZW50LmJvZHkKfSkK) already.
bmeurer commented 2025-09-18 13:35:09 +02:00 (Migrated from github.com)
Copy link

Oh, just realized that the copied URL from the playground doesn't include the contents 👀 , so here's the TypeScript:

class X {
  initialize(
      completions: (this: X, expression: string) => Promise<T[]>,    stopCharacters?: string): void {
    this.loadCompletions = completions;
    this.completionStopCharacters = stopCharacters || ' =:[({;,!+-*/&|^<>.';
    this.usesSuggestionBuilder = usesSuggestionBuilder || false;
  }
}
Oh, just realized that the copied URL from the playground doesn't include the contents 👀 , so here's the TypeScript: ```typescript class X { initialize( completions: (this: X, expression: string) => Promise<T[]>, stopCharacters?: string): void { this.loadCompletions = completions; this.completionStopCharacters = stopCharacters || ' =:[({;,!+-*/&|^<>.'; this.usesSuggestionBuilder = usesSuggestionBuilder || false; } } ```
marijnh commented 2025-09-18 14:16:24 +02:00 (Migrated from github.com)
Copy link

The issue was the this in the parameter list of the function type. Attached patch should help.

The issue was the `this` in the parameter list of the function type. Attached patch should help.
bmeurer commented 2025-10-01 12:32:48 +02:00 (Migrated from github.com)
Copy link

Thanks!

Thanks!
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.2
1.3.1
1.3.0
1.2.0
1.1.1
1.1.0
1.0.2
1.0.1
1.0.0
0.16.0
0.15.3
0.15.2
0.15.1
0.15.0
0.13.4
0.13.3
0.13.2
0.13.1
0.13.0
0.12.0
0.11.1
0.11.0
0.10.1
0.10.0
0.9.1
0.9.0
0.8.4
0.8.3
0.8.2
0.8.1
0.8.0
0.7.0
0.5.2
0.5.1
0.5.0
0.4.0
0.3.0
0.2.0
0.1.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lezer/javascript#48
No description provided.