lezer/javascript
1
0
Fork 0
Code Issues Pull requests Activity

BlockComment from position is incorrect #52

New issue
Closed
opened 2026-01-25 05:21:08 +01:00 by BlueGreenMagick · 2 comments
BlueGreenMagick commented 2026-01-25 05:21:08 +01:00 (Migrated from github.com)
Copy link

BlockComment from position is incorrect when there are other skipped tokens beforehand.

For example, below is an example code and the tree it is parsed into.
You can see that the BlockComment block's from position is all set to 10 when it should instead be21 and 36 respectively.

let x = 1; // abcde 
/* abc *///xxx
/*abc */ 

{
  "type": "Script",
  "from": 0,
  "to": 47,
  "children": [
    {
      "type": "VariableDeclaration",
      "from": 0,
      "to": 10,
      "children": [
        { "type": "let", "from": 0, "to": 3 },
        { "type": "VariableDefinition", "from": 4, "to": 5 },
        { "type": "Equals", "from": 6, "to": 7 },
        { "type": "Number", "from": 8, "to": 9 },
        { "type": ";", "from": 9, "to": 10 }
      ]
    },
    { "type": "LineComment", "from": 11, "to": 20 },
    { "type": "BlockComment", "from": 10, "to": 30 },
    { "type": "LineComment", "from": 30, "to": 35 },
    { "type": "BlockComment", "from": 10, "to": 44 }
  ]
}

Version information

@lezer/javascript: 1.5.4
@lezer/common: 1.5.0
@lezer/lr@1.4.7
BlockComment `from` position is incorrect when there are other skipped tokens beforehand. For example, below is an example code and the tree it is parsed into. You can see that the `BlockComment` block's `from` position is all set to `10` when it should instead be`21` and `36` respectively. ```ts let x = 1; // abcde /* abc *///xxx /*abc */ ``` ```json { "type": "Script", "from": 0, "to": 47, "children": [ { "type": "VariableDeclaration", "from": 0, "to": 10, "children": [ { "type": "let", "from": 0, "to": 3 }, { "type": "VariableDefinition", "from": 4, "to": 5 }, { "type": "Equals", "from": 6, "to": 7 }, { "type": "Number", "from": 8, "to": 9 }, { "type": ";", "from": 9, "to": 10 } ] }, { "type": "LineComment", "from": 11, "to": 20 }, { "type": "BlockComment", "from": 10, "to": 30 }, { "type": "LineComment", "from": 30, "to": 35 }, { "type": "BlockComment", "from": 10, "to": 44 } ] } ``` ### Version information ``` @lezer/javascript: 1.5.4 @lezer/common: 1.5.0 @lezer/lr@1.4.7 ```
marijnh commented 2026-01-25 13:38:12 +01:00 (Migrated from github.com)
Copy link

This was a regression in @lezer/lr 1.4.6. Version 1.4.8 should fix it.

This was a regression in @lezer/lr 1.4.6. Version 1.4.8 should fix it.
BlueGreenMagick commented 2026-01-25 13:56:14 +01:00 (Migrated from github.com)
Copy link

Thanks for such a quick fix! 1.4.8 fixed the issue 😃

Thanks for such a quick fix! 1.4.8 fixed the issue 😃
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
1.5.4
1.5.3
1.5.2
1.5.1
1.5.0
1.4.21
1.4.20
1.4.19
1.4.18
1.4.17
1.4.16
1.4.15
1.4.14
1.4.13
1.4.12
1.4.11
1.4.10
1.4.9
1.4.8
1.4.7
1.4.6
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.2
1.3.1
1.3.0
1.2.0
1.1.1
1.1.0
1.0.2
1.0.1
1.0.0
0.16.0
0.15.3
0.15.2
0.15.1
0.15.0
0.13.4
0.13.3
0.13.2
0.13.1
0.13.0
0.12.0
0.11.1
0.11.0
0.10.1
0.10.0
0.9.1
0.9.0
0.8.4
0.8.3
0.8.2
0.8.1
0.8.0
0.7.0
0.5.2
0.5.1
0.5.0
0.4.0
0.3.0
0.2.0
0.1.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lezer/javascript#52
No description provided.