lezer/xml
1
0
Fork 0
Code Issues Pull requests Activity

Why define a hash function when strict: false? #6

New issue
Closed
opened 2024-04-23 23:23:46 +02:00 by AlexErrant · 1 comment
AlexErrant commented 2024-04-23 23:23:46 +02:00 (Migrated from github.com)
Copy link

github.com/lezer-parser/xml@331ab3dd94/src/tokens.js (L51-L52)

The hash documentation states:

Only needed for strict contexts.

Since we're not in a strict context, why define a hash function?

https://github.com/lezer-parser/xml/blob/331ab3dd94446f3b2594e71e8ff68be57c2e33a4/src/tokens.js#L51-L52 [The `hash` documentation](https://lezer.codemirror.net/docs/ref/#lr.ContextTracker.constructor^spec.hash) states: > Only needed for strict contexts. Since we're _not_ in a strict context, why define a `hash` function?
marijnh commented 2024-04-24 08:09:18 +02:00 (Migrated from github.com)
Copy link

That seems to be leftover and indeed, entirely unused. Attached patches remove it.

That seems to be leftover and indeed, entirely unused. Attached patches remove it.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
1.0.6
1.0.5
1.0.4
1.0.3
1.0.2
1.0.1
1.0.0
0.16.0
0.15.1
0.15.0
0.13.4
0.13.3
0.13.2
0.13.1
0.13.0
0.12.0
0.11.1
0.11.0
0.10.1
0.10.0
0.9.0
0.8.2
0.8.1
0.8.0
0.7.0
0.5.1
0.5.0
0.4.0
0.3.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lezer/xml#6
No description provided.