Destructured params are not linked

adrianheine commented

2019-08-14 14:54:16 +02:00

(Migrated from github.com)

delimitedIndent({closing: string, align⁠?: boolean}) → IndentStrategy

closing and align are not linked

countColumn(line: string, pos: number) → number

line and pos are links to itself

> delimitedIndent({closing: string, align⁠?: boolean}) → IndentStrategy `closing` and `align` are not linked > countColumn(line: string, pos: number) → number `line` and `pos` are links to itself

marijnh commented

2019-08-14 15:24:05 +02:00

(Migrated from github.com)

Isn't the latter how all anchors in the output behave? (I.e. countColumn also links to itself.)

Isn't the latter how all anchors in the output behave? (I.e. `countColumn` also links to itself.)

adrianheine commented

2019-08-15 10:50:00 +02:00

(Migrated from github.com)

Oh yeah, I was complaining about the first behavior, not the second. With adrianheine/gettypes@dce415bd90, there's no __0 for the destructured arg, and so there's no anchor for that argument at all.

Oh yeah, I was complaining about the first behavior, not the second. With adrianheine/gettypes@dce415bd901377ab7574980c13b0bed17fb785b9, there's no `__0` for the destructured arg, and so there's no anchor for that argument at all.

marijnh commented

2019-08-15 10:55:08 +02:00

(Migrated from github.com)

Ah, I see. What would you want to happen in this case?

adrianheine commented

2019-08-15 11:41:50 +02:00

(Migrated from github.com)

I think it would make sense to handle regular and destructured args the same, i. e. put anchors on both if you want arguments to have anchors. If it's not straightforward to implement we can probably accept the current behavior, though.

Rows
Columns

Destructured params are not linked #14