Design decision for GOOD_LEAF_SIZE value #1

New issue

Closed

opened 2018-06-13 00:54:38 +02:00 by bradleyayers · 3 comments

bradleyayers commented 2018-06-13 00:54:38 +02:00 (Migrated from github.com)

Copy link

Curious how the value for GOOD_LEAF_SIZE is determined? Would be great to have that knowledge documented.

Curious how the value for `GOOD_LEAF_SIZE` is determined? Would be great to have that knowledge documented.

marijnh commented 2018-06-13 08:13:24 +02:00 (Migrated from github.com)

Copy link

I believe I mostly just guessed, ran a crude benchmark with a few different sizes, and went with the one that came out ahead.

I believe I mostly just guessed, ran a crude benchmark with a few different sizes, and went with the one that came out ahead.

👍 1

bradleyayers commented 2018-06-13 08:30:41 +02:00 (Migrated from github.com)

Copy link

Sounds good. If you've got the benchmark handy that would be cool to include, if not 🤷🏻‍♂️

Sounds good. If you've got the benchmark handy that would be cool to include, if not 🤷🏻‍♂️

marijnh commented 2018-06-13 08:47:09 +02:00 (Migrated from github.com)

Copy link

I think I just ran the test suite—probably with the SIZE constant set higher.

I think I just ran the test suite—probably with the `SIZE` constant set higher.

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.2

1.2.1

1.2.0

1.1.0

1.0.0

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

marijn/rope-sequence#1

No description provided.