marijn/w3c-keyname
1
0
Fork 0
Code Issues Pull requests Releases Activity

Use native event.key on Chrome versions >=56 #1

New issue
Closed
opened 2016-11-14 18:43:21 +01:00 by marijnh · 3 comments
marijnh commented 2016-11-14 18:43:21 +01:00 (Migrated from github.com)
Copy link

See https://bugs.chromium.org/p/chromium/issues/detail?id=633838 and a8d1819f9c . Once we're sure this is fixed, the code should detect the Chrome version and only apply the kludge for version <56.

See https://bugs.chromium.org/p/chromium/issues/detail?id=633838 and a8d1819f9c2c75762 . Once we're sure this is fixed, the code should detect the Chrome version and only apply the kludge for version <56.
👍 2
marijnh commented 2016-11-18 10:56:28 +01:00 (Migrated from github.com)
Copy link

Still broken in 56.0.2914.3 dev (64-bit)

Still broken in 56.0.2914.3 dev (64-bit)
tyrasd commented 2016-11-18 12:06:42 +01:00 (Migrated from github.com)
Copy link

It works for me in 57.0.2925.0 dev (64-bit)

It works for me in 57.0.2925.0 dev (64-bit)
marijnh commented 2017-01-03 21:58:39 +01:00 (Migrated from github.com)
Copy link

Chrome 57 has finally arrived for Linux, so I was able to confirm this. Attached patch disables the workaround for Chrome versions >=57.

Chrome 57 has finally arrived for Linux, so I was able to confirm this. Attached patch disables the workaround for Chrome versions >=57.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
2.2.8
2.2.7
2.2.6
2.2.5
2.2.4
2.2.3
2.2.2
2.2.1
2.2.0
2.1.1
2.1.0
2.0.0
1.1.8
1.1.7
1.1.6
1.1.5
1.1.3
1.1.2
1.1.1
1.1.0
1.0.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
marijn/w3c-keyname#1
No description provided.