marijn/w3c-keyname
1
0
Fork 0
Code Issues Pull requests Releases Activity

Shift-Tab is "Unidentified" #13

New issue
Closed
opened 2022-07-24 08:54:54 +02:00 by FPurchess · 2 comments
FPurchess commented 2022-07-24 08:54:54 +02:00 (Migrated from github.com)
Copy link

Binding Shift-Tab in prosemirror-keymap results in an unexpected behaviour originally cased by this package. Though the KeyboardEvent is clearly recognized as Tab with a shift-modifier (event.keyCode === 9 && event.shiftKey), the key is marked as "Unidentified".

Here's the user agent (using prosemirror in https://github.com/tauri-apps/tauri):
Mozilla/5.0 (X11; Ubuntu; Linux x86_64) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.0 Safari/605.1.15

However, I can confirm that the Tab gets detected in Firefox & Chrome thought.

Binding `Shift-Tab` in prosemirror-keymap results in an unexpected behaviour originally cased by this package. Though the `KeyboardEvent` is clearly recognized as Tab with a shift-modifier (`event.keyCode === 9 && event.shiftKey`), the key is marked as `"Unidentified"`. Here's the user agent (using prosemirror in https://github.com/tauri-apps/tauri): `Mozilla/5.0 (X11; Ubuntu; Linux x86_64) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.0 Safari/605.1.15` However, I can confirm that the Tab gets detected in Firefox & Chrome thought.
marijnh commented 2022-07-24 10:55:17 +02:00 (Migrated from github.com)
Copy link

Funny, seems that mess of a browser sets event.key to "Unidentified" when shift is held for some reason. Attached patch allows keyName to ignore the key property in that case.

Funny, seems that mess of a browser sets `event.key` to `"Unidentified"` when shift is held for some reason. Attached patch allows `keyName` to ignore the `key` property in that case.
FPurchess commented 2022-07-24 12:46:19 +02:00 (Migrated from github.com)
Copy link

Thank @marijnh ❤️ much appreciated!

Thank @marijnh ❤️ much appreciated!
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
2.2.8
2.2.7
2.2.6
2.2.5
2.2.4
2.2.3
2.2.2
2.2.1
2.2.0
2.1.1
2.1.0
2.0.0
1.1.8
1.1.7
1.1.6
1.1.5
1.1.3
1.1.2
1.1.1
1.1.0
1.0.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
marijn/w3c-keyname#13
No description provided.