marijn/w3c-keyname
1
0
Fork 0
Code Issues Pull requests Releases Activity

Document the base export #6

New issue
Closed
opened 2019-03-05 23:13:56 +01:00 by justinfagnani · 2 comments
justinfagnani commented 2019-03-05 23:13:56 +01:00 (Migrated from github.com)
Copy link

I tried to convert CodeMirror 6's key handler to just use KeyboardEvent.key (only to workaround #5), and it seemed fine, except that I didn't know what the platform equivalent of base was.

I tried to convert CodeMirror 6's key handler to just use KeyboardEvent.key (only to workaround #5), and it seemed fine, except that I didn't know what the platform equivalent of `base` was.
marijnh commented 2019-03-06 09:10:55 +01:00 (Migrated from github.com)
Copy link

and it seemed fine

Except on browsers that have broken support for .key, which are all IE versions (which uses some non-standard names) along with most browsers on macOS (which report the wrong names when some modifier keys are held). So unfortunately, we're going to continue to need this kludge for the time being.

Attached patch documents base and shift.

> and it seemed fine Except on browsers that have broken support for `.key`, which are all IE versions (which uses some non-standard names) along with most browsers on macOS (which report the wrong names when some modifier keys are held). So unfortunately, we're going to continue to need this kludge for the time being. Attached patch documents `base` and `shift`.
justinfagnani commented 2019-03-06 19:23:59 +01:00 (Migrated from github.com)
Copy link

Except on browsers that have broken support for .key

Yeah, I knew it was likely problematic on other browsers, but even on Chrome I didn't know what the equivalent to base was.

Thanks for the notes!

> Except on browsers that have broken support for .key Yeah, I knew it was likely problematic on other browsers, but even on Chrome I didn't know what the equivalent to `base` was. Thanks for the notes!
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
2.2.8
2.2.7
2.2.6
2.2.5
2.2.4
2.2.3
2.2.2
2.2.1
2.2.0
2.1.1
2.1.0
2.0.0
1.1.8
1.1.7
1.1.6
1.1.5
1.1.3
1.1.2
1.1.1
1.1.0
1.0.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
marijn/w3c-keyname#6
No description provided.