Parameter menuContent is too strictly typed #16

New issue

Closed

opened 2023-08-30 15:15:45 +02:00 by SamMousa · 0 comments

SamMousa commented 2023-08-30 15:15:45 +02:00 (Migrated from github.com)

Copy link

The type definition for the parameter references the implementing class not the interface.

github.com/ProseMirror/prosemirror-example-setup@c3ac29c599/src/index.ts (L58-L70)

If you look at the implementation it passes the menuContent, or if not set the the generated menu.
The generated menu is typed less strictly:
github.com/ProseMirror/prosemirror-example-setup@c3ac29c599/src/menu.ts (L167)

The type definition for the parameter references the implementing class not the interface. https://github.com/ProseMirror/prosemirror-example-setup/blob/c3ac29c5998e1b6aa48883f7faf88e8094fb56aa/src/index.ts#L58-L70 If you look at the implementation it passes the `menuContent`, or if not set the the generated menu. The generated menu is typed less strictly: https://github.com/ProseMirror/prosemirror-example-setup/blob/c3ac29c5998e1b6aa48883f7faf88e8094fb56aa/src/menu.ts#L167

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

1.2.3

1.2.2

1.2.1

1.2.0

1.1.2

1.1.1

1.1.0

1.0.1

1.0.0

0.24.0

0.23.1

0.23.0

0.22.0

0.21.0

0.20.0

0.19.0

0.18.0

0.17.0

0.16.0

0.15.0

0.14.0

0.13.0

0.12.0

0.11.1

0.11.0

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

prosemirror/prosemirror-example-setup#16

No description provided.