bug in lists #51

New issue

Closed

opened 2021-01-01 04:36:53 +01:00 by williamstein · 6 comments

williamstein commented 2021-01-01 04:36:53 +01:00 (Migrated from github.com)

Copy link

In the demo, clear the plain textbox and type:

* item
* another item

Then switch to WYSIWYM, then switch back, and you'll see

* item

* another item

This means something completely different in markdown -- it's a list with lots of space between each entry.

As far as I can tell, there isn't a way to even make a bulleted list without lots of space between entries using the WYSIWYM mode.

---

View the difference via Github's Markdown Renderer:

• item
• another item

VERSUS

• item

• another item

In [the demo](https://prosemirror.net/examples/markdown/), clear the plain textbox and type: ``` * item * another item ``` Then switch to WYSIWYM, then switch back, and you'll see ``` * item * another item ``` This means something completely different in markdown -- it's a list with lots of space between each entry. As far as I can tell, there isn't a way to even make a bulleted list without lots of space between entries using the WYSIWYM mode. --- View the difference via Github's Markdown Renderer: * item * another item VERSUS * item * another item

👍 1

williamstein commented 2021-01-01 04:38:54 +01:00 (Migrated from github.com)

Copy link

The same issue occurs with enumerated lists.

The same issue occurs with enumerated lists.

marijnh commented 2021-01-01 16:11:02 +01:00 (Migrated from github.com)

Copy link

It seems that the markdown parser isn't setting the tight attribute (which stores the difference between the two types of Markdown lists), which is likely the source of this problem. I haven't checked how the current version of markdown-it exposes that, but I guess it shouldn't be too hard to fix that. Want to try creating a patch?

It seems that the markdown parser isn't setting the `tight` attribute (which stores the difference between the two types of Markdown lists), which is likely the source of this problem. I haven't checked how the current version of markdown-it exposes that, but I guess it shouldn't be too hard to fix that. Want to try creating a patch?

williamstein commented 2021-01-03 00:10:04 +01:00 (Migrated from github.com)

Copy link

I haven't checked how the current version of markdown-it exposes that, [...]

I figured out how it does; markdown-it has a "hidden" attribute that the Prosemirror parser is ignoring. See https://markdown-it.github.io/markdown-it/#Token.prototype.hidden for the docs about it. In particular,

"If it's true, ignore this element when rendering. Used for tight lists to hide paragraphs."

Probably they used this approach as a sort of annoying hack to make their codebase easier to maintain...

Want to try creating a patch?

Unsure.

> I haven't checked how the current version of markdown-it exposes that, [...] I figured out how it does; markdown-it has a "hidden" attribute that the Prosemirror parser is ignoring. See https://markdown-it.github.io/markdown-it/#Token.prototype.hidden for the docs about it. In particular, > "If it's true, ignore this element when rendering. Used for tight lists to hide paragraphs." Probably they used this approach as a sort of annoying hack to make their codebase easier to maintain... > Want to try creating a patch? Unsure.

marijnh commented 2021-01-06 18:07:55 +01:00 (Migrated from github.com)

Copy link

Attached patch seems to fix this.

Attached patch seems to fix this.

stephane-klein commented 2023-08-02 13:23:39 +02:00 (Migrated from github.com)

Copy link

Attached patch seems to fix this.

@marijnh where is this patch? 🤔.

> Attached patch seems to fix this. @marijnh where is this patch? :thinking:.

marijnh commented 2023-08-02 17:43:47 +02:00 (Migrated from github.com)

Copy link

Probably in the link right above my comment.

github.com/ProseMirror/prosemirror-markdown@64f7027973

Probably in the link right above my comment. https://github.com/ProseMirror/prosemirror-markdown/commit/64f70279732344c4b5deef821c108fff3484bd66

👍 1

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

1.13.4

1.13.3

1.13.2

1.13.1

1.13.0

1.12.0

1.11.2

1.11.1

1.11.0

1.10.1

1.10.0

1.9.4

1.9.3

1.9.2

1.9.1

1.9.0

1.8.0

1.7.1

1.7.0

1.6.2

1.6.1

1.6.0

1.5.2

1.5.1

1.5.0

1.4.5

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.2

1.3.1

1.3.0

1.2.2

1.2.1

1.2.0

1.1.1

1.1.0

1.0.4

1.0.3

1.0.2

1.0.1

1.0.0

0.24.0

0.23.0

0.22.0

0.21.0

0.20.0

0.19.0

0.18.0

0.17.0

0.16.0

0.15.0

0.14.0

0.13.0

0.12.0

0.11.1

0.11.0

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

prosemirror/prosemirror-markdown#51

No description provided.