prosemirror/prosemirror-markdown
1
0
Fork 0
Code Issues 3 Pull requests Activity

Add support for passing an extra env dictionary to the MarkdownSerializer #98

New issue
Closed
opened 2023-05-16 14:28:40 +02:00 by segevfiner · 5 comments
segevfiner commented 2023-05-16 14:28:40 +02:00 (Migrated from github.com)
Copy link

This is useful for serialization rules that need additional data or configuration that isn't part of the document.

This is useful for serialization rules that need additional data or configuration that isn't part of the document.
marijnh commented 2023-05-17 09:58:27 +02:00 (Migrated from github.com)
Copy link

Why not just have your serializer functions close over the data they need?

Why not just have your serializer functions close over the data they need?
segevfiner commented 2023-05-17 11:33:44 +02:00 (Migrated from github.com)
Copy link

I don't want to create a new instance of MarkdownSerializer for each parse
cycle.

בתאריך יום ד׳, 17 במאי 2023, 10:58, מאת Marijn Haverbeke ‏<
@.***>:

Why not just have your serializer functions close over the data they need?

—
Reply to this email directly, view it on GitHub
https://github.com/ProseMirror/prosemirror-markdown/issues/98#issuecomment-1550933213,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF4WB76FE32XU3UQK6NCI7TXGSAK3ANCNFSM6AAAAAAYDSL3IE
.
You are receiving this because you authored the thread.Message ID:
@.***>

I don't want to create a new instance of MarkdownSerializer for each parse cycle. בתאריך יום ד׳, 17 במאי 2023, 10:58, מאת Marijn Haverbeke ‏< ***@***.***>: > Why not just have your serializer functions close over the data they need? > > — > Reply to this email directly, view it on GitHub > <https://github.com/ProseMirror/prosemirror-markdown/issues/98#issuecomment-1550933213>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AF4WB76FE32XU3UQK6NCI7TXGSAK3ANCNFSM6AAAAAAYDSL3IE> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> >
marijnh commented 2023-05-17 13:38:24 +02:00 (Migrated from github.com)
Copy link

Wouldn't you have to do the same if you pass in the env as an object?

Wouldn't you have to do the same if you pass in the env as an object?
segevfiner commented 2023-05-17 13:39:59 +02:00 (Migrated from github.com)
Copy link

I only need to create the env object and pass it to serialize, reusing the same global MarkdownSerializer.

I only need to create the env object and pass it to `serialize`, reusing the same global `MarkdownSerializer`.
marijnh commented 2023-05-17 15:12:31 +02:00 (Migrated from github.com)
Copy link

Ah, I see, it's an argument to serialize. Still, this seems to address a highly specific use case that's easily enough worked around by putting the values you need to access in some shared variable, so I don't think this needs to be in the library.

Ah, I see, it's an argument to `serialize`. Still, this seems to address a highly specific use case that's easily enough worked around by putting the values you need to access in some shared variable, so I don't think this needs to be in the library.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
1.13.4
1.13.3
1.13.2
1.13.1
1.13.0
1.12.0
1.11.2
1.11.1
1.11.0
1.10.1
1.10.0
1.9.4
1.9.3
1.9.2
1.9.1
1.9.0
1.8.0
1.7.1
1.7.0
1.6.2
1.6.1
1.6.0
1.5.2
1.5.1
1.5.0
1.4.5
1.4.4
1.4.3
1.4.2
1.4.1
1.4.0
1.3.2
1.3.1
1.3.0
1.2.2
1.2.1
1.2.0
1.1.1
1.1.0
1.0.4
1.0.3
1.0.2
1.0.1
1.0.0
0.24.0
0.23.0
0.22.0
0.21.0
0.20.0
0.19.0
0.18.0
0.17.0
0.16.0
0.15.0
0.14.0
0.13.0
0.12.0
0.11.1
0.11.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-markdown#98
No description provided.