The menu buttons are spans, semantically they should be buttons #20

Open
opened 2019-06-10 12:48:43 +02:00 by canvaspixels · 3 comments
canvaspixels commented 2019-06-10 12:48:43 +02:00 (Migrated from github.com)

It would be great if the menu buttons were tabbable straight out of the box which you'll get for free if they're <button>s

It would be great if the menu buttons were tabbable straight out of the box which you'll get for free if they're` <button>s`
marijnh commented 2019-06-11 20:38:12 +02:00 (Migrated from github.com)

I think they were, at one point, but I ran into issues with styling. A pull request that makes them buttons + makes them look the way they look now would be very welcome.

I think they were, at one point, but I ran into issues with styling. A pull request that makes them buttons + makes them look the way they look now would be very welcome.
sanghunlee-711 commented 2025-05-12 06:54:48 +02:00 (Migrated from github.com)

@marijnh @canvaspixels Can i try this issue? if there isn't any plan to do this

@marijnh @canvaspixels Can i try this issue? if there isn't any plan to do this
marijnh commented 2025-05-12 14:20:45 +02:00 (Migrated from github.com)

Of course!

Of course!
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-menu#20
No description provided.