prosemirror/prosemirror-menu
1
0
Fork 0
Code Issues 7 Pull requests Activity

iOS - Sticky toolbar does not stick #3

New issue
Open
opened 2016-12-09 11:48:39 +01:00 by marijnh · 4 comments
marijnh commented 2016-12-09 11:48:39 +01:00 (Migrated from github.com)
Copy link

See https://github.com/ProseMirror/prosemirror/issues/223

See https://github.com/ProseMirror/prosemirror/issues/223
Dev1an commented 2019-04-11 17:05:01 +02:00 (Migrated from github.com)
Copy link

What about using sticky positioning in CSS instead of Javascript?

See:

What about using sticky positioning in CSS instead of Javascript? See: - [MDN documentation](https://developer.mozilla.org/en-US/docs/Web/CSS/position) on `position: sticky` - [Browser compatibility](https://caniuse.com/#feat=css-sticky)
marijnh commented 2019-04-11 17:17:50 +02:00 (Migrated from github.com)
Copy link

Yes, we know about position: sticky. Back in 2016 it was terribly broken in iOS. Not sure what the current situation is.

Yes, we know about position: sticky. Back in 2016 it was terribly broken in iOS. Not sure what the current situation is.
Dev1an commented 2019-04-11 20:34:58 +02:00 (Migrated from github.com)
Copy link

The stickyness with CSS works on iOS. I tried it locally and it works fine. Shall I create a new pull request with this feature?

The stickyness with CSS works on iOS. I tried it locally and it works fine. Shall I create a new pull request with this feature?
marijnh commented 2019-04-12 10:27:55 +02:00 (Migrated from github.com)
Copy link

Sure! Though I think we'd want to keep the existing implementation for browsers where sticky isn't supported.

Sure! Though I think we'd want to keep the existing implementation for browsers where sticky isn't supported.
👍 1
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
1.3.0
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.4
1.1.3
1.1.2
1.1.1
1.1.0
1.0.5
1.0.4
1.0.3
1.0.2
1.0.1
1.0.0
0.24.0
0.23.0
0.22.0
0.21.0
0.20.0
0.19.0
0.18.0
0.17.1
0.17.0
0.16.0
0.15.0
0.14.0
0.13.0
0.12.0
0.11.1
0.11.0
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-menu#3
No description provided.