Wrong types information in package.json #8

Closed
opened 2022-05-22 20:11:28 +02:00 by peterblazejewicz · 2 comments
peterblazejewicz commented 2022-05-22 20:11:28 +02:00 (Migrated from github.com)

Hey folks,
AFAIK the package does not distribute declaration types, contrary to entry in package.json:
https://github.com/ProseMirror/prosemirror-test-builder/blob/master/package.json#L8
this can lead to issues when TS automatic types acquisition feature is being used by users.
There is existing @types/prosemirror-test-builder at the same time.
What's the source of the truth for typings?
https://www.npmjs.com/package/@types/prosemirror-test-builder
Thanks!

Hey folks, AFAIK the package does not distribute declaration types, contrary to entry in `package.json`: https://github.com/ProseMirror/prosemirror-test-builder/blob/master/package.json#L8 this can lead to issues when TS automatic types acquisition feature is being used by users. There is existing @types/prosemirror-test-builder at the same time. What's the source of the truth for typings? https://www.npmjs.com/package/@types/prosemirror-test-builder Thanks!
marijnh commented 2022-05-23 07:30:17 +02:00 (Migrated from github.com)

Which version of the package are you referring to? The regular versions should have neither a types entry nor a .d.ts file, and the current beta version should have both.

Which version of the package are you referring to? The regular versions should have neither a `types` entry nor a .d.ts file, and the current beta version should have both.
peterblazejewicz commented 2022-05-23 22:21:24 +02:00 (Migrated from github.com)

I'm really sorry for not being specific. I meant 1.0.6, but now realized I missed the point (and the correct version as you pointed). Sorry for the noise :)

I'm really sorry for not being specific. I meant 1.0.6, but now realized I missed the point (and the correct version as you pointed). Sorry for the noise :)
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-test-builder#8
No description provided.