prosemirror/prosemirror-view
1
5
Fork 4
Code Pull requests 1 Activity

Add an update method to custom mark views #197

Merged
marijn merged 4 commits from ocavue/prosemirror-view:mark-view-update into main 2026-07-01 17:48:52 +02:00
Conversation 5 Commits 4 Files changed 2 +69 -2
ocavue commented 2026-06-29 01:20:50 +02:00
Contributor
Copy link

Add a new method MarkView.update(), similar to existing NodeView.update().

This can avoid DOM rebuilds for some expensive custom mark views (imagine a custom link mark view that needs to render the favicon and OG image).

Add a new method `MarkView.update()`, similar to existing [`NodeView.update()`](https://prosemirror.net/docs/ref/#view.NodeView.update). This can avoid DOM rebuilds for some expensive custom mark views (imagine a custom `link` mark view that needs to render the favicon and OG image).
marijn reviewed 2026-07-01 16:15:47 +02:00
src/viewdesc.ts Outdated
@ -1220,0 +1227,4 @@
// When nothing matches, try to update the mark view at this position
// in place, so a custom mark view can adapt to a changed mark without
// re-creating its DOM.
if (found < 0) {
marijn commented 2026-07-01 16:15:47 +02:00
Owner
Copy link

could you add an && this.index < this.top.children.length here to avoid out-of-bounds access? (Which would be caught by the instanceof check but could still cause deoptimization.)

could you add an `&& this.index < this.top.children.length` here to avoid out-of-bounds access? (Which would be caught by the `instanceof` check but could still cause deoptimization.)
ocavue commented 2026-07-01 16:47:31 +02:00
Author
Contributor
Copy link

done.

done.
marijn merged commit e6323215ac into main 2026-07-01 17:48:52 +02:00
marijn commented 2026-07-01 17:48:57 +02:00
Owner
Copy link

Thanks!

Thanks!
marijn commented 2026-07-01 17:49:25 +02:00
Owner
Copy link

Shall I tag a release or are you planning more PRs?

Shall I tag a release or are you planning more PRs?
ocavue commented 2026-07-01 18:00:29 +02:00
Author
Contributor
Copy link

@marijn wrote in #197 (comment):

Shall I tag a release or are you planning more PRs?

You can tag a release. I don’t have any planning PRs for now.

@marijn wrote in https://code.haverbeke.berlin/prosemirror/prosemirror-view/pulls/197#issuecomment-70218: > Shall I tag a release or are you planning more PRs? You can tag a release. I don’t have any planning PRs for now.
marijn commented 2026-07-01 19:16:17 +02:00
Owner
Copy link

Done (1.42.0)

Done (1.42.0)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
prosemirror/prosemirror-view!197
No description provided.