codemirror/autocomplete
1
0
Fork 0
Code Pull requests Activity

Declare state and view peer dependencies #12

Closed
sugar700 wants to merge 1 commit from declare-peer-dependencies into main
pull from: declare-peer-dependencies
merge into: codemirror:main
Conversation 2 Commits 1 Files changed 1 +4 -2
sugar700 commented 2022-06-14 07:41:12 +02:00 (Migrated from github.com)
Copy link

The user is going to need to put those into package.json themselves, whether it's by adding codemirror or @codemirror/view. As such there is no issue with those being peer dependencies.

See https://github.com/codemirror/dev/issues/858.

The user is going to need to put those into package.json themselves, whether it's by adding codemirror or @codemirror/view. As such there is no issue with those being peer dependencies. See https://github.com/codemirror/dev/issues/858.
marijnh commented 2022-06-15 08:05:18 +02:00 (Migrated from github.com)
Copy link

I'm leaning towards, as a more general solution, to really put all @codemirror and @lezer dependencies on all these packages in both peer- and regular dependency fields (using tooling to make sure they stay in sync). Does that sound like a reasonable solution to you? I'd start, as a pilot, with this package.

I'm leaning towards, as a more general solution, to really put all @codemirror and @lezer dependencies on all these packages in both peer- and regular dependency fields (using tooling to make sure they stay in sync). Does that sound like a reasonable solution to you? I'd start, as a pilot, with this package.
sugar700 commented 2022-06-15 08:07:48 +02:00 (Migrated from github.com)
Copy link

Sure.

Sure.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/autocomplete!12
No description provided.