Bring back pickedCompletion annotation for apply: string | undefined #14

Merged

fonsp merged 2 commits from patch-1 into main 2022-11-10 13:33:03 +01:00

Conversation 1 Commits 2 Files changed 1 +4 -1

fonsp commented 2022-11-10 13:24:33 +01:00 (Migrated from github.com)

Copy link

In v0.20.0, the transaction generated by applyCompletion added the annotation pickedCompletion.of(option.completion) automatically. The docs suggest that this is intended:

github.com/codemirror/autocomplete@83ba89266e/src/completion.ts (L24-L26)

This behaviour is missing in the current version (since github.com/codemirror/autocomplete@758ecc3ba6), this PR adds it back.

In v0.20.0, the transaction generated by `applyCompletion` added the annotation `pickedCompletion.of(option.completion)` automatically. The docs suggest that this is intended: https://github.com/codemirror/autocomplete/blob/83ba89266efa90b41b0bca23c2fb615b5c7e8346/src/completion.ts#L24-L26 This behaviour is missing in the current version (since https://github.com/codemirror/autocomplete/commit/758ecc3ba6638d38db8254a96871b90c0c9343a3), this PR adds it back.

marijnh commented 2022-11-10 13:33:11 +01:00 (Migrated from github.com)

Copy link

Thank you for spotting that!

Thank you for spotting that!

❤️ 1

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

codemirror/autocomplete!14

No description provided.