codemirror/autocomplete
1
0
Fork 0
Code Pull requests Activity

Export startCompletionEffect and closeCompletionEffect #25

Closed
ankoh wants to merge 1 commit from main into main
pull from: main
merge into: codemirror:main
Conversation 4 Commits 1 Files changed 1 +1 -1
ankoh commented 2024-08-18 19:09:27 +02:00 (Migrated from github.com)
Copy link

This commit is exposing startCompletionEffect and closeCompletionEffect.
It allows us to modify StateFields whenever the completion popup opens/closes.

This commit is exposing startCompletionEffect and closeCompletionEffect. It allows us to modify StateFields whenever the completion popup opens/closes.
ankoh commented 2024-08-18 19:13:56 +02:00 (Migrated from github.com)
Copy link

Let me know if there's a better way to update StateFields whenever the completion is either applied or aborted.
I thought about hooking into Candidate apply, CompletionResult validFor and CompletionResult map, but you're still missing some cases where the completion is, for example, canceled by deleting the whole word.

Let me know if there's a better way to update StateFields whenever the completion is either applied or aborted. I thought about hooking into Candidate apply, CompletionResult validFor and CompletionResult map, but you're still missing some cases where the completion is, for example, canceled by deleting the whole word.
ankoh commented 2024-08-18 19:16:25 +02:00 (Migrated from github.com)
Copy link

Ah, I just found that mine is a duplicate of https://github.com/codemirror/autocomplete/pull/24 , sorry.

Ah, I just found that mine is a duplicate of https://github.com/codemirror/autocomplete/pull/24 , sorry.
ankoh commented 2024-08-18 19:16:51 +02:00 (Migrated from github.com)
Copy link

Feel free to close if you don't like exposing the effect, I'll use the workaround of #24 in the meantime.

Feel free to close if you don't like exposing the effect, I'll use the workaround of #24 in the meantime.
marijnh commented 2024-08-18 20:20:22 +02:00 (Migrated from github.com)
Copy link

Yeah these are really intended to be internal.

Yeah these are really intended to be internal.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/autocomplete!25
No description provided.