codemirror/autocomplete
1
0
Fork 0
Code Pull requests Activity

feat: only work with the last match in case where the regex contains global flag #27

Closed
nsrCodes wants to merge 1 commit from fix-matchBefore-global-flag-case into main
pull from: fix-matchBefore-global-flag-case
merge into: codemirror:main
Conversation 0 Commits 1 Files changed 1 +9 -1
nsrCodes commented 2025-01-22 17:58:20 +01:00 (Migrated from github.com)
Copy link

fixes: https://github.com/codemirror/dev/issues/1510

I have handled this explicitly for expressions with a global flag, but I feel the last match is the match that should be used in every case here.
The existing extra logic in ensureAnchor makes me believe there are some conditions that I might not be aware of, hence the explicit global case.

fixes: https://github.com/codemirror/dev/issues/1510 I have handled this explicitly for expressions with a global flag, but I feel the last match is _the_ match that should be used in every case here. The existing extra logic in `ensureAnchor` makes me believe there are some conditions that I might not be aware of, hence the explicit global case.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/autocomplete!27
No description provided.