Make @codemirror/state a peerdependency #28

Closed
simhnna wants to merge 1 commit from make-state-peer-dep into main
simhnna commented 2025-04-11 21:51:23 +02:00 (Migrated from github.com)

It should only be installed once, so it's wrong to configure it as a dependency.

package managers like pnpm will install the dependency under autocomplete so you can end up with multiple installations of state which breaks codemirror

It should only be installed once, so it's wrong to configure it as a dependency. package managers like pnpm will install the dependency under autocomplete so you can end up with multiple installations of state which breaks codemirror
marijnh commented 2025-04-11 22:18:53 +02:00 (Migrated from github.com)

That's a pnpm issue. npm (and yarn for the most part) will properly deduplicate depdencies. Peer dependencies have their own issue and gotchas, and aren't a usable solution for a dependency like this.

That's a pnpm issue. npm (and yarn for the most part) will properly deduplicate depdencies. Peer dependencies have their own issue and gotchas, and aren't a usable solution for a dependency like this.

Pull request closed

Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/autocomplete!28
No description provided.