Use the mapped result when remapping an ActiveResult through changes #31

Merged

marijn merged 1 commit from ondrejmirtes/autocomplete:active-result-map-fix into main

2026-06-03 16:47:41 +02:00

ondrejmirtes commented

2026-06-02 21:54:11 +02:00

Contributor

ActiveResult.map(mapping) was calling result.map(...) to remap the result through doc changes that the active completion survives, but then constructing the new ActiveResult from this.result (the original). That meant additionalTextEdit positions and any other state a source rewrites in its map function were silently discarded along this code path.

`ActiveResult.map(mapping)` was calling `result.map(...)` to remap the result through doc changes that the active completion survives, but then constructing the `new ActiveResult` from `this.result` (the original). That meant additionalTextEdit positions and any other state a source rewrites in its map function were silently discarded along this code path.

ondrejmirtes added 1 commit

2026-06-02 21:54:11 +02:00

Use the mapped result when remapping an ActiveResult through changes 0875032b25

ActiveResult.map(mapping) was calling result.map(...) to remap the result through doc changes that the active completion survives, but then constructing the new ActiveResult from this.result (the original). That meant additionalTextEdit positions and any other state a source rewrites in its map function were silently discarded along this code path.

ondrejmirtes referenced this pull request from codemirror/lsp-client

2026-06-02 22:01:20 +02:00

Apply additionalTextEdits from completion items #7