codemirror/basic-setup
1
0
Fork 0
Code Pull requests Activity

document basicSetup includes historyKeymap #5

Closed
fredsa wants to merge 3 commits from patch-1 into main
pull from: patch-1
merge into: codemirror:main
Conversation 4 Commits 3 Files changed 1 +10 -10
fredsa commented 2026-02-18 08:18:41 +01:00 (Migrated from github.com)
Copy link

Make it clear that the undo history keymap is included as part of basicSetup and minimalSetup as this wasn't entirely clear from the https://codemirror.net/docs/ref/ documentation. Users might also assume that undo keybindings are included within defaultKeymap (which they are not).

Make it clear that the undo history keymap is included as part of basicSetup and minimalSetup as this wasn't entirely clear from the https://codemirror.net/docs/ref/ documentation. Users might also assume that undo keybindings are included within defaultKeymap (which they are not).
marijnh (Migrated from github.com) reviewed 2026-02-18 09:02:40 +01:00
src/codemirror.ts
@ -19,25 +19,25 @@ import {lintKeymap} from "@codemirror/lint"
///
marijnh (Migrated from github.com) commented 2026-02-18 09:02:40 +01:00
Copy link

You have a stray slash here at the start of the link target.

You have a stray slash here at the start of the link target.
marijnh commented 2026-02-18 09:05:32 +01:00 (Migrated from github.com)
Copy link

Thanks. But maybe we can keep this a bit more succinct by including it on the line that mentions "the undo history" as "and keymap" (separate link)?

Thanks. But maybe we can keep this a bit more succinct by including it on the line that mentions "the undo history" as "and keymap" (separate link)?
fredsa commented 2026-02-18 17:52:47 +01:00 (Migrated from github.com)
Copy link

Happy to oblige and apologies for the typo.
Fixes applied, made a few more edits to cleanup and clarify keymaps.

Feel free to make additional edits based on your preferred style of formatting if that's easier than back and forth comments.

In case you've not heard this enough: CodeMirror has brought much joy to so many developers. That includes me. Much appreciated!

Happy to oblige and apologies for the typo. Fixes applied, made a few more edits to cleanup and clarify keymaps. Feel free to make additional edits based on your preferred style of formatting if that's easier than back and forth comments. In case you've not heard this enough: CodeMirror has brought much joy to so many developers. That includes me. Much appreciated!
marijnh commented 2026-02-19 08:41:02 +01:00 (Migrated from github.com)
Copy link

Thanks, merged as 80d81b6

Thanks, merged as 80d81b6

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/basic-setup!5
No description provided.