Horizontal scroll bar obstructs last line of text after Paste in FireFox #3821

Closed
opened 2016-02-12 00:11:05 +01:00 by marijnh · 7 comments
marijnh commented 2016-02-12 00:11:05 +01:00 (Migrated from gitlab.com)

Steps to Repro:

  1. Use FireFox (Chrome does not repro)
  2. Go to https://codemirror.net/demo/fullscreen.html
  3. Delete all text in the editor
  4. Enter a bunch of text so the vertical scroll bar appears, but NOT the horizontal scroll bar, and also make sure there is no new line at the bottom of the editor.
  5. PASTE text (to any line but the last) to cause the horzontal scroll bar to appear

=> scroll to the bottom left of the editor and notice the horizontal scrollbar is partially obstructing the last line of text

codemirrorhorizscrollpaste

Steps to Repro: 1. Use FireFox (Chrome does not repro) 2. Go to https://codemirror.net/demo/fullscreen.html 3. Delete all text in the editor 4. Enter a bunch of text so the vertical scroll bar appears, but NOT the horizontal scroll bar, and also make sure there is no new line at the bottom of the editor. 5. PASTE text (to any line but the last) to cause the horzontal scroll bar to appear => scroll to the bottom left of the editor and notice the horizontal scrollbar is partially obstructing the last line of text ![codemirrorhorizscrollpaste](https://cloud.githubusercontent.com/assets/17186762/12993656/50e13e98-d0d0-11e5-9e42-64efaf946040.PNG)
marijnh commented 2016-02-17 16:56:53 +01:00 (Migrated from gitlab.com)

I am not able to reproduce this. Here's concretely how I'm following your instructions:

  • Open the fullscreen demo.
  • Select all content of the editor, press ctrl-x to cut
  • Spam letter keys until there line is long enough to cause a horizontal scrollbar
  • Move to the middle of the the line (or don't, both cause the same outcome)
  • Press ctrl-v to paste

The cursor now moves to the end of the pasted content, near the bottom of the document, and the last line is visible, above the horizontal scrollbar. If I add a few extra lines so that pasting doesn't put the cursor on the last line, the problem still does not show itself.

This is Firefox 44 Linux. Which OS are you testing on?

I am not able to reproduce this. Here's concretely how I'm following your instructions: - Open the fullscreen demo. - Select all content of the editor, press ctrl-x to cut - Spam letter keys until there line is long enough to cause a horizontal scrollbar - Move to the middle of the the line (or don't, both cause the same outcome) - Press ctrl-v to paste The cursor now moves to the end of the pasted content, near the bottom of the document, and the last line is visible, above the horizontal scrollbar. If I add a few extra lines so that pasting doesn't put the cursor on the last line, the problem still does not show itself. This is Firefox 44 Linux. Which OS are you testing on?
marijnh commented 2016-02-18 22:58:19 +01:00 (Migrated from gitlab.com)

Thanks for getting back to me!

I see this on Firefox 43.0.1, Windows 7 and Firefox 41.0.2, Mac OSX Yosemite.

I think you went wrong on step 4 - you should spam letter keys until the Vertical scrollbar appears.

Thanks for getting back to me! I see this on Firefox 43.0.1, Windows 7 and Firefox 41.0.2, Mac OSX Yosemite. I think you went wrong on step 4 - you should spam letter keys until the **Vertical** scrollbar appears.
marijnh commented 2016-02-19 14:31:09 +01:00 (Migrated from gitlab.com)

Ah, sorry for the poor reading. Looks like a bug (or at least strangeness) in Firefox's interpretation of a padding I'm setting. Attached patch seems to work around it. Does it help?

Ah, sorry for the poor reading. Looks like a bug (or at least strangeness) in Firefox's interpretation of a padding I'm setting. Attached patch seems to work around it. Does it help?
marijnh commented 2018-06-28 16:04:13 +02:00 (Migrated from gitlab.com)

mentioned in merge request !7312

mentioned in merge request !7312
marijnh commented 2018-06-28 18:14:55 +02:00 (Migrated from gitlab.com)

mentioned in issue #147

mentioned in issue #147
marijnh commented 2018-09-06 18:04:48 +02:00 (Migrated from gitlab.com)

I suppose the patch fixed this. Feel free to re-open if that is not the case.

I suppose the patch fixed this. Feel free to re-open if that is not the case.
marijnh (Migrated from gitlab.com) closed this issue 2018-09-06 18:04:48 +02:00
marijnh commented 2021-02-08 07:34:57 +01:00 (Migrated from gitlab.com)

mentioned in issue #6584

mentioned in issue #6584
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/codemirror5#3821
No description provided.