codemirror/codemirror5
1
0
Fork 0
Code Issues 412 Pull requests Activity

Updated XML parser #7312

Closed
marijnh wants to merge 3 commits from github/fork/deebugger/master into master
pull from: github/fork/deebugger/master
merge into: codemirror:master
Conversation 1 Commits 3 Files changed 2 +432 -210
marijnh commented 2011-07-26 14:35:44 +02:00 (Migrated from gitlab.com)
Copy link

Not sure why the pull request was closed (by me, for some reason), but this is a newer one, with better handling of XML declaration and attributes.

Not sure why the pull request was closed (by me, for some reason), but this is a newer one, with better handling of XML declaration and attributes.
marijnh commented 2011-08-12 16:26:44 +02:00 (Migrated from gitlab.com)
Copy link

Hey. You may be wondering why this was left unanswered for so long. There are two reasons. First, I'm an unorganized slob. Second, your mode seems to be unfinished, and doesn't handle HTML anymore. Thus, it is not viable to simply merge it into the main repository. If you polish it up further, and move it into a new mode/ subdirectory, I'll gladly take a closer look.

Hey. You may be wondering why this was left unanswered for so long. There are two reasons. First, I'm an unorganized slob. Second, your mode seems to be unfinished, and doesn't handle HTML anymore. Thus, it is not viable to simply merge it into the main repository. If you polish it up further, and move it into a new mode/ subdirectory, I'll gladly take a closer look.
marijnh (Migrated from gitlab.com) closed this pull request 2011-08-12 16:26:44 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/codemirror5!7312
No description provided.