codemirror/codemirror5
1
0
Fork 0
Code Issues 412 Pull requests Activity

[vim] Support text objects in visual mode #10006

Closed
marijnh wants to merge 1 commit from github/fork/mightyguava/textobject into master
pull from: github/fork/mightyguava/textobject
merge into: codemirror:master
Conversation 3 Commits 1 Files changed 2 +73 -14
marijnh commented 2014-10-09 04:25:39 +02:00 (Migrated from gitlab.com)
Copy link

@heppe please review at your convenience. I had to make a few small changes to the key handling code because i and a in the text object keys conflicted with their enter insert mode equivalents.

`@heppe` please review at your convenience. I had to make a few small changes to the key handling code because `i` and `a` in the text object keys conflicted with their enter insert mode equivalents.
marijnh commented 2014-10-09 04:26:04 +02:00 (Migrated from gitlab.com)
Copy link

This change is to address https://github.com/codemirror/CodeMirror/issues/2847

This change is to address https://github.com/codemirror/CodeMirror/issues/2847
marijnh commented 2014-10-10 04:51:11 +02:00 (Migrated from gitlab.com)
Copy link

@heppe PTAL. Addressed comments, but it looks like the force push wiped them out.

`@heppe` PTAL. Addressed comments, but it looks like the force push wiped them out.
marijnh commented 2014-10-11 02:13:51 +02:00 (Migrated from gitlab.com)
Copy link

Merged as 6d04226

Merged as 6d04226
marijnh (Migrated from gitlab.com) closed this pull request 2014-10-11 02:15:34 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/codemirror5!10006
No description provided.