codemirror/codemirror5
1
0
Fork 0
Code Issues 412 Pull requests Activity

[vim] Use keymap binding instead of event handlers #10101

Closed
marijnh wants to merge 1 commit from github/fork/mightyguava/keymap into master
pull from: github/fork/mightyguava/keymap
merge into: codemirror:master
Conversation 11 Commits 1 Files changed 1 +113 -93
marijnh commented 2014-11-24 02:11:25 +01:00 (Migrated from gitlab.com)
Copy link

Revert back to using CodeMirror keymap for key handling instead of direct key handlers.
https://github.com/codemirror/CodeMirror/issues/2915
@heppe please review at your convenience. @nightwing you probably have to add a proxy for the call property on keymaps in ACE github.com/codemirror/CodeMirror@dd2b9d86ac

Revert back to using CodeMirror keymap for key handling instead of direct key handlers. https://github.com/codemirror/CodeMirror/issues/2915 ` @heppe` please review at your convenience.` @nightwing` you probably have to add a proxy for the `call` property on keymaps in ACE https://github.com/codemirror/CodeMirror/commit/dd2b9d86ac30feb74c0bf0b999893382cd9f1e07
marijnh commented 2014-11-24 17:33:33 +01:00 (Migrated from gitlab.com)
Copy link

can you be more specific here?

can you be more specific here?
marijnh commented 2014-11-24 17:40:57 +01:00 (Migrated from gitlab.com)
Copy link

why is that a problem?

why is that a problem?
marijnh commented 2014-11-25 04:26:21 +01:00 (Migrated from gitlab.com)
Copy link

Technically, it's not, but we want to match vim where possible, so I added a TODO to document it.

Technically, it's not, but we want to match vim where possible, so I added a TODO to document it.
marijnh commented 2014-11-25 04:33:17 +01:00 (Migrated from gitlab.com)
Copy link

Fixed, I was just being lazy.

Fixed, I was just being lazy.
marijnh commented 2014-11-25 18:32:00 +01:00 (Migrated from gitlab.com)
Copy link

It looks like there's still a bunch of places where the callers are expecting command.

It looks like there's still a bunch of places where the callers are expecting command.
marijnh commented 2014-11-25 18:33:19 +01:00 (Migrated from gitlab.com)
Copy link

not a new problem, but can you put a log message here into the console? Do we have any mechanism to do that?

not a new problem, but can you put a log message here into the console? Do we have any mechanism to do that?
marijnh commented 2014-11-25 22:20:44 +01:00 (Migrated from gitlab.com)
Copy link

(If you really want a console.log in production code, write console["log"] to prevent the linter from complaining.)

(If you really want a `console.log` in production code, write `console["log"]` to prevent the linter from complaining.)
marijnh commented 2014-11-27 05:06:14 +01:00 (Migrated from gitlab.com)
Copy link

I don't understand what you mean by this. findKey is a new function added to use for CodeMirror keymap's call param. handleKey's API has not changed, so there should not be any side effects

I don't understand what you mean by this. `findKey` is a new function added to use for CodeMirror keymap's `call` param. `handleKey`'s API has not changed, so there should not be any side effects
marijnh commented 2014-12-03 08:45:02 +01:00 (Migrated from gitlab.com)
Copy link

on lines 238 and 635 you are assigning command = findkey(), and then testing against 'function', but findkey is defined as returning true or false.

Or maybe I'm missing something.

on lines 238 and 635 you are assigning command = findkey(), and then testing against 'function', but findkey is defined as returning true or false. Or maybe I'm missing something.
marijnh commented 2014-12-04 04:02:06 +01:00 (Migrated from gitlab.com)
Copy link

Ah, the documentation is out of date. Updated.

Ah, the documentation is out of date. Updated.
marijnh commented 2014-12-06 19:31:30 +01:00 (Migrated from gitlab.com)
Copy link

Merged as 4fad3f8

Merged as 4fad3f8
marijnh (Migrated from gitlab.com) closed this pull request 2014-12-06 19:31:30 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/codemirror5!10101
No description provided.