codemirror/codemirror5
1
0
Fork 0
Code Issues 412 Pull requests Activity

Update misc.js #7148 bugfix #14312

Merged
marijnh merged 2 commits from github/fork/joejoseph00/master into master 2026-02-05 21:14:53 +01:00
Conversation 8 Commits 2 Files changed 1 +1 -1
marijnh commented 2026-02-05 06:11:13 +01:00 (Migrated from gitlab.com)
Copy link

For background information, multiple bug reports reports https://drupal.org/i/3531472 confirming this fix.
API changes have occurred in CKEditor 5 v45.0 that break the plugin. This change fixes it.

For background information, multiple bug reports reports https://drupal.org/i/3531472 confirming this fix. API changes have occurred in CKEditor 5 v45.0 that break the plugin. This change fixes it.
marijnh commented 2026-02-05 16:05:44 +01:00 (Migrated from gitlab.com)
Copy link

I've been using the fix for a few months successfully in production.

I've been using the fix for a few months successfully in production.
marijnh commented 2026-02-05 16:06:48 +01:00 (Migrated from gitlab.com)
Copy link

mentioned in issue #7148

mentioned in issue #7148
marijnh commented 2026-02-05 21:14:53 +01:00 (Migrated from gitlab.com)
Copy link

Merged by: marijnh at 2026-02-05 20:14:53 UTC

*Merged by: marijnh at 2026-02-05 20:14:53 UTC*
marijnh (Migrated from gitlab.com) closed this pull request 2026-02-05 21:14:53 +01:00
marijnh (Migrated from gitlab.com) merged commit into master 2026-02-05 21:14:53 +01:00
marijnh commented 2026-02-05 21:15:36 +01:00 (Migrated from gitlab.com)
Copy link

Thanks!

Thanks!
marijnh commented 2026-02-05 22:17:42 +01:00 (Migrated from gitlab.com)
Copy link

@marijnh would you please be so kind as to tag and release 5.65.21 with this fix?

`@marijnh` would you please be so kind as to tag and release 5.65.21 with this fix?
marijnh commented 2026-02-07 08:52:36 +01:00 (Migrated from gitlab.com)
Copy link

There's a version 5.65.21 out now.

There's a version 5.65.21 out now.
marijnh commented 2026-02-08 20:49:09 +01:00 (Migrated from gitlab.com)
Copy link

registry.npmjs.org shows .21 exists but our project is stuck on .8

somehow unable to get a composer update or is not in asset-packagist.org or packagist.org isn't updated or is somehow pinned on 5.65.8 max.

Root composer.json requires codemirror/codemirror ^5.65.21, found codemirror/codemirror[5.65.8] but it does not match the constraint.

I'm trying to chase this down.

registry.npmjs.org shows .21 exists but our project is stuck on .8 somehow unable to get a composer update or is not in asset-packagist.org or packagist.org isn't updated or is somehow pinned on 5.65.8 max. <code>Root composer.json requires codemirror/codemirror ^5.65.21, found codemirror/codemirror[5.65.8] but it does not match the constraint.</code> I'm trying to chase this down.
marijnh commented 2026-02-08 21:09:08 +01:00 (Migrated from gitlab.com)
Copy link

Ok I figured this out, I'll unwind the issue on our side, you've done the right thing, your release is working well thank you!

My 5.65.8 is comming from d . o ckeditor_codemirror/composer.libraries.json , I'll bark up a new tree now, thank you very much for fixing this issue and for tagging and releasing!

Ok I figured this out, I'll unwind the issue on our side, you've done the right thing, your release is working well thank you! My 5.65.8 is comming from d . o ckeditor_codemirror/composer.libraries.json , I'll bark up a new tree now, thank you very much for fixing this issue and for tagging and releasing!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/codemirror5!14312
No description provided.