codemirror/codemirror5
1
0
Fork 0
Code Issues 412 Pull requests Activity

[vim] blockwise paste #9909

Closed
marijnh wants to merge 5 commits from github/fork/binora/blockwise_paste into master
pull from: github/fork/binora/blockwise_paste
merge into: codemirror:master
Conversation 6 Commits 5 Files changed 2 +116 -29
marijnh commented 2014-08-05 21:48:28 +02:00 (Migrated from gitlab.com)
Copy link

blockwise paste implementation

blockwise paste implementation
marijnh commented 2014-08-05 21:51:50 +02:00 (Migrated from gitlab.com)
Copy link

@mightyguava @heppe Please have a look.

`@mightyguava` `@heppe` Please have a look.
marijnh commented 2014-08-05 21:55:57 +02:00 (Migrated from gitlab.com)
Copy link

I found 2 bugs so far.

  1. The block ends up getting pasted in the column before the cursor. It should be on the column after the cursor.
  2. If the column the cursor on exceeds the length of the line below, vim should extend the line below with whitespace/tabs to match the column. Right now it just pastes to the end of the line.
I found 2 bugs so far. 1. The block ends up getting pasted in the column before the cursor. It should be on the column after the cursor. 2. If the column the cursor on exceeds the length of the line below, vim should extend the line below with whitespace/tabs to match the column. Right now it just pastes to the end of the line.
marijnh commented 2014-08-05 21:56:44 +02:00 (Migrated from gitlab.com)
Copy link

mentioned in issue #1032

mentioned in issue #1032
marijnh commented 2014-08-06 19:19:12 +02:00 (Migrated from gitlab.com)
Copy link

@mightyguava I wasn't able to repro #1 from your list, but I don't see a commit after your comment, so I'm not sure how it might have been fixed.

I was able to see #2, however, and it's worse than you describe. It doesn't paste at the end of the line, but rather chucks out whatever contents were on the line past the shortest line that is touched by the pasted block. That definitely needs a fix and a test before this can be submitted.

`@mightyguava` I wasn't able to repro #1 from your list, but I don't see a commit after your comment, so I'm not sure how it might have been fixed. I was able to see #2, however, and it's worse than you describe. It doesn't paste at the end of the line, but rather chucks out whatever contents were on the line past the shortest line that is touched by the pasted block. That definitely needs a fix and a test before this can be submitted.
marijnh commented 2014-08-11 20:01:38 +02:00 (Migrated from gitlab.com)
Copy link

LGTM. This looks ready to merge.

LGTM. This looks ready to merge.
marijnh commented 2014-08-11 20:15:06 +02:00 (Migrated from gitlab.com)
Copy link

Merged as 9de315b

Merged as 9de315b
marijnh (Migrated from gitlab.com) closed this pull request 2014-08-11 20:15:06 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/codemirror5!9909
No description provided.