codemirror/commands
1
0
Fork 0
Code Pull requests Activity

Add selectNextOccurrence command #1

Closed
Daninet wants to merge 1 commit from main into main
pull from: main
merge into: codemirror:main
Conversation 2 Commits 1 Files changed 1 +66 -1
Daninet commented 2021-04-04 20:48:13 +02:00 (Migrated from github.com)
Copy link

Hey there. First of all, congratulations for this awesome library. 👏😊

I was learning about the new version and I noticed that it doesn't have a selectNextOccurrence command, so I implemented it. It tries to mimic the Ctrl-D command from VS Code and Sublime.

This is my first contribution here. Any comments and suggestions will be appreciated :)

Hey there. First of all, congratulations for this awesome library. 👏😊 I was learning about the new version and I noticed that it doesn't have a `selectNextOccurrence` command, so I implemented it. It tries to mimic the Ctrl-D command from VS Code and Sublime. This is my first contribution here. Any comments and suggestions will be appreciated :)
marijnh commented 2021-04-06 11:50:54 +02:00 (Migrated from github.com)
Copy link

Thanks for the contribution. I think this would fit better in the @codemirror/search package though—commands does not currently depend on search, and there it could reuse the wordAt helper in src/selection-match.ts to cut out some of the verbosity. Would you mind creating a PR against that repository instead?

Thanks for the contribution. I think this would fit better in the `@codemirror/search` package though—`commands` does not currently depend on `search`, and there it could reuse the `wordAt` helper in `src/selection-match.ts` to cut out some of the verbosity. Would you mind creating a PR against that repository instead?
👍 1
Daninet commented 2021-04-06 20:02:27 +02:00 (Migrated from github.com)
Copy link

Created new PR here: https://github.com/codemirror/search/pull/1

Created new PR here: https://github.com/codemirror/search/pull/1

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/commands!1
No description provided.