codemirror/dev
1
2
Fork 0
Code Issues 16 Pull requests Activity

Windows build fixes: yarn and docs #515

Merged
microbit-matt-hillsdon merged 2 commits from windows-fix into master 2021-06-21 11:34:34 +02:00
Conversation 4 Commits 2 Files changed 2 +6 -5
microbit-matt-hillsdon commented 2021-06-20 16:22:35 +02:00 (Migrated from github.com)
Copy link

Full fix also requires changes to buildhelper on https://github.com/codemirror/buildhelper/pull/3

With these two fixes the following work for me on Windows:

  • node ./bin/cm.js install
  • node ./bin/cm.js build
  • node ./bin/cm.js devserver
    • rebuilds changes to demo
    • rebuilds changes to packages

See https://github.com/codemirror/codemirror.next/issues/425

Full fix also requires changes to buildhelper on https://github.com/codemirror/buildhelper/pull/3 With these two fixes the following work for me on Windows: - node ./bin/cm.js install - node ./bin/cm.js build - node ./bin/cm.js devserver - rebuilds changes to demo - rebuilds changes to packages See https://github.com/codemirror/codemirror.next/issues/425
microbit-matt-hillsdon commented 2021-06-20 16:26:03 +02:00 (Migrated from github.com)
Copy link

The run args vs options thing felt quite subjective. Happy to rework as you prefer. Seemed good not to have to specify either default in the common case.

The run args vs options thing felt quite subjective. Happy to rework as you prefer. Seemed good not to have to specify either default in the common case.
marijnh commented 2021-06-20 22:03:52 +02:00 (Migrated from github.com)
Copy link

Thanks for looking into this. I'd prefer for the working dir arg to run to stay a positional argument (since it's used very often), and the options argument to become the fourth argument.

Thanks for looking into this. I'd prefer for the working dir arg to `run` to stay a positional argument (since it's used very often), and the options argument to become the fourth argument.
marijnh (Migrated from github.com) reviewed 2021-06-21 10:08:38 +02:00
bin/cm.js
@ -60,8 +60,8 @@ function error(err) {
process.exit(1)
marijnh (Migrated from github.com) commented 2021-06-21 10:08:38 +02:00
Copy link

Isn't this missing an = {} to avoid making the argument required? Looks like it will error now when called with 2 or 3 arguments.

Isn't this missing an `= {}` to avoid making the argument required? Looks like it will error now when called with 2 or 3 arguments.
microbit-matt-hillsdon (Migrated from github.com) reviewed 2021-06-21 10:21:18 +02:00
bin/cm.js
@ -60,8 +60,8 @@ function error(err) {
process.exit(1)
microbit-matt-hillsdon (Migrated from github.com) commented 2021-06-21 10:21:17 +02:00
Copy link

Yes, thanks. Updated. I've now tested with the status command too.

Yes, thanks. Updated. I've now tested with the status command too.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/dev!515
No description provided.