Add at-rules #3

Closed

jamesnw wants to merge 2 commits from at-rules into main

pull from: at-rules

merge into: codemirror:main

codemirror:main

Conversation 3 Commits 2 Files changed 1 +8

jamesnw commented 2024-09-06 22:48:10 +02:00 (Migrated from github.com)

Copy link

This adds autocompletion for CSS at rules, based on the list at https://developer.mozilla.org/en-US/docs/Web/CSS/At-rule.

This adds autocompletion for CSS at rules, based on the list at https://developer.mozilla.org/en-US/docs/Web/CSS/At-rule.

marijnh commented 2024-09-07 12:41:30 +02:00 (Migrated from github.com)

Copy link

Nice. Would it make sense to make the completion type for these "keyword" instead of "class", since they play the role of syntactic keywords in this language?

Nice. Would it make sense to make the completion type for these `"keyword"` instead of `"class"`, since they play the role of syntactic keywords in this language?

jamesnw commented 2024-09-07 12:53:41 +02:00 (Migrated from github.com)

Copy link

Nice. Would it make sense to make the completion type for these "keyword" instead of "class", since they play the role of syntactic keywords in this language?

Good call- I've made the change.

> Nice. Would it make sense to make the completion type for these `"keyword"` instead of `"class"`, since they play the role of syntactic keywords in this language? Good call- I've made the change.

marijnh commented 2024-09-07 13:01:13 +02:00 (Migrated from github.com)

Copy link

Thanks! Merged as f280a6a

Thanks! Merged as f280a6a

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

codemirror/lang-css!3

No description provided.