codemirror/lang-example
1
0
Fork 0
Code Issues Pull requests Activity

Remove package lock from git ignore #16

Closed
StoneCypher wants to merge 3 commits from RemovePackageLockFromGitIgnore into main
pull from: RemovePackageLockFromGitIgnore
merge into: codemirror:main
Conversation 0 Commits 3 Files changed 1 -1
StoneCypher commented 2022-09-18 20:05:33 +02:00 (Migrated from github.com)
Copy link

Your tooling is excellent

One small point: package-lock should be in the repo, for three reasons.

  1. This is how supply chain attacks can be investigated and prevented
  2. A ci/cd path needs package.lock to do its installs; otherwise if it creates one on the spot it's not testing code as committed, but code as would have been created at any given time, and is subject to library drift
  3. Several code scanners eg snyk treat it as positive signal and rank upwards for it

This PR removes package-lock from .gitignore. A subsequent PR will add an actual package lockfile, so that if you decide you want to do that yourself you can merge this, but if you don't want to be bothered you can just merge both.

Fixes codemirror/lang-example#15 (identical text)

Your tooling is excellent One small point: package-lock should be in the repo, for three reasons. 1. This is how supply chain attacks can be investigated and prevented 2. A ci/cd path needs package.lock to do its installs; otherwise if it creates one on the spot it's not testing code as committed, but code as would have been created at any given time, and is subject to library drift 3. Several code scanners eg snyk treat it as positive signal and rank upwards for it This PR removes package-lock from .gitignore. A subsequent PR will add an actual package lockfile, so that if you decide you want to do that yourself you can merge this, but if you don't want to be bothered you can just merge both. Fixes codemirror/lang-example#15 (identical text)

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/lang-example!16
No description provided.