codemirror/lang-example
1
0
Fork 0
Code Issues Pull requests Activity

Major bump #21

Merged
yvan-sraka merged 1 commit from main into main 2025-07-28 08:30:32 +02:00
Conversation 6 Commits 1 Files changed 3 +9 -7
yvan-sraka commented 2025-07-24 15:13:50 +02:00 (Migrated from github.com)
Copy link

I upgraded all dependencies to their latest versions, and npm install && npm run test pass (tested with Node.js v22.16.0 :)

I upgraded all dependencies to their latest versions, and `npm install && npm run test` pass (tested with Node.js `v22.16.0` :)
marijnh (Migrated from github.com) reviewed 2025-07-24 15:13:50 +02:00
marijnh (Migrated from github.com) reviewed 2025-07-24 15:22:04 +02:00
tsconfig.json
@ -8,2 +8,3 @@
"moduleResolution": "node"
"moduleResolution": "node",
"outDir": "dist"
},
marijnh (Migrated from github.com) commented 2025-07-24 15:22:04 +02:00
Copy link

Since we're not using TS directly to generate output, why specify an outDir here?

Since we're not using TS directly to generate output, why specify an `outDir` here?
marijnh (Migrated from github.com) reviewed 2025-07-24 15:23:43 +02:00
package.json
@ -30,3 +30,4 @@
"typescript": "^5.8.3"
},
"license": "MIT"
}
marijnh (Migrated from github.com) commented 2025-07-24 15:23:43 +02:00
Copy link

What's the reason for including tslib here?

What's the reason for including tslib here?
yvan-sraka (Migrated from github.com) reviewed 2025-07-25 17:31:29 +02:00
package.json
@ -30,3 +30,4 @@
"typescript": "^5.8.3"
},
"license": "MIT"
}
yvan-sraka (Migrated from github.com) commented 2025-07-25 17:31:29 +02:00
Copy link
> rollup -c
src/index.ts → dist/index.cjs, ./dist...
[!] (plugin typescript) RollupError: [plugin typescript] @rollup/plugin-typescript: Could not find module 'tslib', which is required by this plugin. Is it installed?
``` > rollup -c src/index.ts → dist/index.cjs, ./dist... [!] (plugin typescript) RollupError: [plugin typescript] @rollup/plugin-typescript: Could not find module 'tslib', which is required by this plugin. Is it installed? ```
yvan-sraka (Migrated from github.com) reviewed 2025-07-25 17:32:14 +02:00
tsconfig.json
@ -8,2 +8,3 @@
"moduleResolution": "node"
"moduleResolution": "node",
"outDir": "dist"
},
yvan-sraka (Migrated from github.com) commented 2025-07-25 17:32:14 +02:00
Copy link
> rollup -c
src/index.ts → dist/index.cjs, ./dist...
[!] (plugin typescript) RollupError: [plugin typescript] @rollup/plugin-typescript: You are using one of Typescript's compiler options 'declaration', 'declarationMap' or 'composite'. In this case 'outDir' or 'declarationDir' must be specified to generate declaration files.
``` > rollup -c src/index.ts → dist/index.cjs, ./dist... [!] (plugin typescript) RollupError: [plugin typescript] @rollup/plugin-typescript: You are using one of Typescript's compiler options 'declaration', 'declarationMap' or 'composite'. In this case 'outDir' or 'declarationDir' must be specified to generate declaration files. ```
marijnh commented 2025-07-28 08:31:29 +02:00 (Migrated from github.com)
Copy link

Thanks! Merged.

Thanks! Merged.
🎉 1
Sign in to join this conversation.
Reviewers
No reviewers
marijnh
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/lang-example!21
No description provided.