codemirror/lang-html
1
0
Fork 0
Code Pull requests Activity

Make auto-closing tag consume following closing angle bracket #2

Merged
masad-frost merged 1 commit from patch-1 into main 2022-09-27 10:15:59 +02:00
Conversation 2 Commits 1 Files changed 1 +9 -4
masad-frost commented 2022-09-27 02:20:15 +02:00 (Migrated from github.com)
Copy link

This changes the behavior of autoClosingTag extension take into account leading >, it consumes the > instead of adding a new one.

I found this behavior to be more sane as I'm writing code inside codemirror.

Here's a video of the interaction

https://user-images.githubusercontent.com/1994028/192403206-94ef735b-d1e0-4cfa-98c2-c63481e21e7f.mp4

And here's a before interaction

https://user-images.githubusercontent.com/1994028/192403216-8e4e2f3f-2ee2-4793-a567-11444c32fe9b.mp4

This changes the behavior of `autoClosingTag` extension take into account leading `>`, it consumes the `>` instead of adding a new one. I found this behavior to be more sane as I'm writing code inside codemirror. Here's a video of the interaction https://user-images.githubusercontent.com/1994028/192403206-94ef735b-d1e0-4cfa-98c2-c63481e21e7f.mp4 And here's a before interaction https://user-images.githubusercontent.com/1994028/192403216-8e4e2f3f-2ee2-4793-a567-11444c32fe9b.mp4
masad-frost commented 2022-09-27 04:05:56 +02:00 (Migrated from github.com)
Copy link

I can update the JSX auto closing extension if this change makes sense to you.

I can update the JSX auto closing extension if this change makes sense to you.
marijnh commented 2022-09-27 10:17:23 +02:00 (Migrated from github.com)
Copy link

Yes, this looks like a good idea.

Yes, this looks like a good idea.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
codemirror/lang-html!2
No description provided.