Add support for the "selfClosing" dialect.

Uncaught (in promise) Error: Unrecognized extension value in extension set ([object Object]). This sometimes happens because multiple instances of @codemirror/state are loaded, breaking instanceof checks.

Both inside of devtools-frontend as well as in unit tests. https://crrev.com/c/4031632 is the CL. What's suspicous is that rebuild.sh renamed a lot of things to Extension$1.

Any help would be greatly appreciated.

This somehow breaks when I update DevTools front-end to this version. Upon calling `html()` it now throws an exception: ``` Uncaught (in promise) Error: Unrecognized extension value in extension set ([object Object]). This sometimes happens because multiple instances of @codemirror/state are loaded, breaking instanceof checks. ``` Both inside of devtools-frontend as well as in unit tests. https://crrev.com/c/4031632 is the CL. What's suspicous is that `rebuild.sh` renamed a lot of things to `Extension$1`. Any help would be greatly appreciated.

marijnh commented

2022-11-17 14:11:06 +01:00

(Migrated from github.com)

npm duplicated some of your dependencies, which for some reason it often does when upgrading dependency versions. Reinstalling the dependencies and clearing the package lock usually gets rid of it.

bmeurer commented

2022-11-17 14:21:26 +01:00

(Migrated from github.com)

That was my first thought, but the rebuild.sh script wipes the node_modules and package-lock.json.

It seems like the offending extension here is the lezer-parser/javascript. Could you tag a new release?

That was my first thought, but the [`rebuild.sh`](https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/third_party/codemirror.next/rebuild.sh;drc=6da128c3ae6b6dd0d4602059c23f8c4003823f5b) script wipes the `node_modules` and `package-lock.json`. It seems like the offending extension here is the `lezer-parser/javascript`. Could you tag a new release?

marijnh commented

2022-11-17 14:24:13 +01:00

(Migrated from github.com)

It seems like the offending extension here is the lezer-parser/javascript

I don't see how tagging a new release of a package is going to help with this. @lezer/javascript doesn't even export CodeMirror extensions that could lead to this error—it doesn't have any CodeMirror packages as dependencies.

> It seems like the offending extension here is the lezer-parser/javascript I don't see how tagging a new release of a package is going to help with this. @lezer/javascript doesn't even export CodeMirror extensions that could lead to this error—it doesn't have any CodeMirror packages as dependencies.

bmeurer commented

2022-11-17 14:25:12 +01:00

(Migrated from github.com)

Yeah, scratch that.

marijnh commented

2022-11-17 14:37:26 +01:00

(Migrated from github.com)

(That being said, there were some unreleased patches in @lezer/javascript, so I've tagged a 1.1.0.)

bmeurer commented

2022-11-17 16:57:34 +01:00

(Migrated from github.com)

Thanks!

The issue was caused by a @codemirror/view dependency conflict.

Thanks! The issue was caused by a `@codemirror/view` dependency conflict.

Rows
Columns

Add support for the "selfClosing" dialect. #3